Justin Deoliveira ha scritto: > Nice patch! Big but very clean. > > The only minor suggestion/note i have is that > WMSLayerINfoImpl.getWMSLayer() does a lot of work inline. The other > ResourceInfoImpl classes delegate out to ResourcePool for all resource > loading operations. It would be nice to follow that same pattern. > Especially if the proposal to make the catalog classes pure java beans > ever comes to light.
I've updated the patch as you described, and also added in full support for REST Config mimicking (well, actually blatantly copying and adapting) the behavior of data stores and feature types. I also added the same level of testing as the rest of the rest code to the new resource. That made the patch grow quite a bit to a whopping 259k, but... oh well, at this point it's pretty much complete. The only thing that's actually missing is documentation, but I think I'll wait for the dust to settle before tacking that. Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
