On Tue, Oct 12, 2010 at 1:26 AM, Justin Deoliveira <[email protected]> wrote:
> Hi all,
> Recently i have come across a few extensions for wicket that I figure would
> be nice but require wicket 1.4. That and since 1.4 seems to be the current
> stable release I thought I would take a crack at an upgrade. Not the easiest
> upgrade by a long shot but I have a working setup in my github repo [1].
> Before describing what I did I am curious to hear what people think about an
> upgrade? Is now the right time? Or should we push off to 2.2? Personally i
> guess i am +0 on the upgrade. On the one hand there are no crucial issues
> that will be fixed by the upgrade, if anything we will still have issues as
> i am sure there are cases where keys are being referenced that do not exist
> in the property file. we just don't have the test coverage to catch it.
> Before this patch goes through every single page will have to visited
> manually... that or we up test coverage to 100% :) But on the other hand 95%
> of the work is done and if we don't upgrade now the patch will become
> outdated, etc...
I'm favourable to have the patchset hit GeoServer now. GeoServer 2.2 is far
far away and Wicket 1.4 would be replaced by 1.5 by then.
I prefer to see a "one step at a time" approach and switch to Wicket 1.4 before
GeoServer beta2 is relased.
> 6) LayerGroupEditPageTest
> This one i was actually not sure about. It seems the test makes
> some assumptions about how the layer list is structured and perhaps it
> changed.
> ---
> a/web/core/src/test/java/org/geoserver/web/data/layergroup/LayerGroupEditPageTest.java
> +++
> b/web/core/src/test/java/org/geoserver/web/data/layergroup/LayerGroupEditPageTest.java
> @@ -13,8 +13,9 @@ public class LayerGroupEditPageTest extends
> LayerGroupBaseTest {
> tester.assertRenderedPage(LayerGroupEditPage.class);
> // remove the first and second elements
>
> tester.clickLink("form:layers:layers:listContainer:items:1:itemProperties:4:component:link");
> // the regenerated list will have ids starting from 4
> -
> tester.clickLink("form:layers:layers:listContainer:items:4:itemProperties:4:component:link");
> +
> //tester.clickLink("form:layers:layers:listContainer:items:4:itemProperties:4:component:link");
> // manually regenerate bounds
> tester.clickLink("form:generateBounds");
> // print(page, true, true);
>
> Hopefully the author can chime in.
Yeah, to click a link in a list container we need to go through the
full path, I know of no
other way to make it work. What you can do is to use the debug
facilities in our testing
harness to have the structure of the page be printed and see how the
new link path
looks like. See print(Compoenent, boolean, boolean)
> 7) CoverageStoreEditPageTest,DataAccessEditPageTest
> These pages have custom validator on the form that check the data store name
> to ensure that it (a) gets set and (b) does not already exist in the
> catalog. There is also the validator that gets implicitly set since the
> "name" field is required. It seems the order in which they execute is now
> different and the latter executes first. For example:
> ---
> a/web/core/src/test/java/org/geoserver/web/data/store/CoverageStoreEditPageTest.java
> +++
> b/web/core/src/test/java/org/geoserver/web/data/store/CoverageStoreEditPageTest.java
> @@ -55,7 +57,7 @@ public class CoverageStoreEditPageTest extends
> GeoServerWicketTestSupport {
> tester.clickLink("rasterStoreForm:save");
>
> tester.assertRenderedPage(CoverageStoreEditPage.class);
> - tester.assertErrorMessages(new String[] { "Store name is required"
> });
> + tester.assertErrorMessages(new String[] { "Field 'Data Source Name'
> is required." });
> }
Ah, I see. Patch looks good.
Btw, also had a quick look at the full patch on github, looks good too.
Cheers
Andrea
-----------------------------------------------------
Ing. Andrea Aime
Senior Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584962313
fax: +39 0584962313
http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf
-----------------------------------------------------
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
