No objection here. The editor is nicer to use than the original, and there
is no loss of functionality, in fact the opposite in that it has better
support across browsers. So +1 here.
2c.
-Justin
On Sun, Nov 7, 2010 at 2:09 PM, Andrea Aime <[email protected]>wrote:
> On Sat, Nov 6, 2010 at 7:50 PM, Justin Deoliveira <[email protected]>
> wrote:
> > Sorry for the lack of response, did not get a chance to look at this
> until
> > the weekend. All in all I think it looks great and is a big improvement.
> I
> > also took the liberty of exercising my weak css skills to clean up the
> > toolbar icons and make them act a bit more like buttons, as well as added
> > some tooltips. Added the patch to the issue that can be applied on top of
> > the original patch.
> > The full screen issue is a pain. No idea of the right approach there. But
> I
> > think even without the full screen functionality this editor is much
> nicer
> > to use than what is there.
> > All in all great work.
>
> Hey thanks. Merged your patch and added a bit of other minor improvements.
> I guess if nobody else wants to add anything and nobody complains it's
> ready
> to commit.
>
> Well, let me know, if I don't hear back anything else I'll commit it into
> GeoServer sometimes later in the week
>
> Cheers
> Andrea
>
> -----------------------------------------------------
> Ing. Andrea Aime
> Senior Software Engineer
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
>
> phone: +39 0584962313
> fax: +39 0584962313
>
> http://www.geo-solutions.it
> http://geo-solutions.blogspot.com/
> http://www.linkedin.com/in/andreaaime
> http://twitter.com/geowolf
>
> -----------------------------------------------------
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a
Billion" shares his insights and actions to help propel your
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
