On Wed, Feb 23, 2011 at 12:55 PM, David Winslow <[email protected]>wrote:

> I took a stab at addressing the issue (both the disabled extension point
> and the refactoring to ResourceAccessManager) in the patch attached to
> http://jira.codehaus.org/browse/GEOS-4397.


Hi David,
the overall structure of the patch looks good, but I think there is a
problem with the values
returned from the ResourceAccessManager in that it really returns a
DataAccessLimits,
but the secure catalog is expecting specific subclasses to be returned
instead.

If you look at DataAccessManagerAdapter you should see what I mean, if the
layer being
secured is vector a VectorAccessLimits is build, and so on

I only had very short time to look into it but the rest seems fine

Cheers
Andrea

-- 
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy

phone: +39 0584 962313
fax:      +39 0584 962313
mob:    +39 333 8128928

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-------------------------------------------------------
------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to