Hi all, sorry to chime in late on this one. My general opinion is that I don't think it is a great idea to change serialization format mid stable stream, for the reasons Andrea stated. So I agree there. That said I also agree that this restriction is quite limiting when it comes to backporting features. So for this case in particular, i agree with Andrea that on trunk I would say implement it as a addition to the core config (changing the serialization format) but on 2.1.x keep all the config in metadata. I understand that this makes it hard to maintain the work on two branches... but I think that is a better alternative than deal with the mess that would result from changing the serialization format on the stable series.
That said moving forward I agree what we really need is a way to coax xstream into being more lenient when it sees. The solution in the blog post should work well for us although we have the restconfig case to consider. I don't think we should use it in that case since the xml is usually being supplied by the user... and more likely to contain regular syntax errors. We don't want to lose the error reporting capabilities in that case. Also if we do adopt this fix we really need to stress that users should never modify the xml config files manually... since when do they do make a typo or something it will go unrecognized. So I think we need to add a setLax flag to XStreamPersister and only set it when we read the catalog and config from disk, and leave the default behaviour as it is now. 2c. On Thu, Jun 2, 2011 at 8:24 AM, Andrea Aime <andrea.a...@geo-solutions.it>wrote: > On Thu, Jun 2, 2011 at 4:12 PM, Andrea Aime > <andrea.a...@geo-solutions.it> wrote: > > Now, the point would be moot if it was possible to configure XStream > > to ignore those new extra tags. Which is something I tried to do in the > > past, and failed, the patch worked but had very bad side effects > > (can't remember which ones unfortunately, it has been quite some > > time ago) > > Searched again and found these: > http://pvoss.wordpress.com/2009/01/08-/xstream/<http://pvoss.wordpress.com/2009/01/08/xstream/> > http://jira.codehaus.org/browse/XSTR-30 > > Maybe they could work? I guess we could try, the potential issue is that > our xstream stuff is already heavily customized, finger crossed that the > patch does not badly interact with it. > > But there would be no salvation for 2.1.0, it's already out > > Cheers > Andrea > > -- > ------------------------------------------------------- > Ing. Andrea Aime > GeoSolutions S.A.S. > Tech lead > > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > > phone: +39 0584 962313 > fax: +39 0584 962313 > > http://www.geo-solutions.it > http://geo-solutions.blogspot.com/ > http://www.youtube.com/user/GeoSolutionsIT > http://www.linkedin.com/in/andreaaime > http://twitter.com/geowolf > > ------------------------------------------------------- > > > ------------------------------------------------------------------------------ > Simplify data backup and recovery for your virtual environment with > vRanger. > Installation's a snap, and flexible recovery options mean your data is > safe, > secure and there when you need it. Data protection magic? > Nope - It's vRanger. Get your free trial download today. > http://p.sf.net/sfu/quest-sfdev2dev > _______________________________________________ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial.
------------------------------------------------------------------------------ Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Discover what all the cheering's about. Get your free trial download today. http://p.sf.net/sfu/quest-dev2dev2
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
