Great work on this Ian. A very very welcome change. +1 on the proposal (just
updated with my vote). And a few comments.
Regarding the testing... the way you did this is clever :) I think it is
fine for now since it is constrained to a single test class. However if this
pattern pops up again I think it might be worth looking at an alternative
like parameterized tests with junit 4 [1].
Also regarding where this work should take place. Is the intent to commit
this on 2.1.x or not? Often when a significant change like this is
implemented first we apply it to the trunk only, and this gives the change a
bit of extra testing among devs who are using the trunk. Usually if there
are major unforeseen issues they are flushed out within a week or so, making
the backport to 2.1.x smoother. Might be wise to do do that here as well.
-Justin
[1]
http://junit.sourceforge.net/javadoc/org/junit/runners/Parameterized.html
On Wed, Aug 17, 2011 at 4:48 PM, Ian Schneider <ischnei...@opengeo.org>wrote:
> >> 3. Release schedule (fix for version) - up in the air.
> >
> > This is an important detail though. This work is probably warranting a
> GSIP,
> > but if you want to commit on 2.1.x it most definitely needs one.
>
> GSIP 63 under discussion.
>
> http://geoserver.org/display/GEOS/GSIP+63+-+Encrypt+Plaintext+Passwords
>
>
> ------------------------------------------------------------------------------
> Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
> user administration capabilities and model configuration. Take
> the hassle out of deploying and managing Subversion and the
> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
> _______________________________________________
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
user administration capabilities and model configuration. Take
the hassle out of deploying and managing Subversion and the
tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
