On Fri, Dec 9, 2011 at 1:51 PM, Andrea Aime <andrea.a...@geo-solutions.it>wrote:
> Hi all,
> as some of you might now I had the get go to work on WFS paging support
> on the 2.1.x series.
>
> The work is based on Justins's patch here
> http://jira.codehaus.org/browse/GEOS-4485,
> work that has been checked for compatibilty with whatever we have on trunk
> and augmented to address concerns raised when Justin last proposed it on
> the maling list.
>
> The main concern expressed last time was that only a few selected stores
> would
> support paging, in particular only JDBC based ones, but not for example
> shapefiles.
> In the meantime a generic memory/disk based feature sorter has been
> developed
> on trunk that allows to support sorting and offsets (both required for
> paging)
> on top of a generic feature reader/feature iterator.
>
> The improvement made on top of the old patch was to have GeoServer own
> FeatureSource wrapper use the above sorter, backported from geotools trunk
> to 2.7.x, to fully support both sorting and paging on all data store that
> cannot do the service by themselves.
> This is actually more general than what we have on trunk, so I was thinking
> to forward port this change there too.
>
> The original paging tests have been replaced with ones ported back from
> trunk and they keep on working.
>
> After the fact I've noticed that on trunk a similar approach was taken,
> but
> only to support offset without caring for sorting. I thought we wanted to
> have paging
> only when stabilized by a sort, am I mistaken?
> In my patch when a start offset has been specified natural sorting is
> imposed
> even if not asked directly.
>
We went around on this a few times but it was thought that it would be more
desirable to simply do the offset regardless of whether the underlying
format could sort, rather than throw an exception back. Accepting the fact
that using a non sorting store will lead to inconsistent results. This also
seemed to fit with how we handle transactions... allowing them on stores
that can actually can't really do transactions, rather than throwing an
exception back. Not a perfect analogy I know. But the fact that the
mergesort feature stuff was coming down the pipe and we would eventually be
able to supplement the non sorting stores regardless it seemed acceptable.
>
> Anyways, a bit more work seems to be needed in order to harmonize the
> two branches but things appear to be looking good.
>
> I've attached the two updated patches on the jira, look for the AA suffix:
> http://jira.codehaus.org/browse/GEOS-4485
>
Looked over the patches and they look good to me. Do we have a handle on
the issues merging with trunk?
>
> Cheers
> Andrea
>
> --
> -------------------------------------------------------
> Ing. Andrea Aime
> GeoSolutions S.A.S.
> Tech lead
>
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
>
> phone: +39 0584 962313
> fax: +39 0584 962313
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://geo-solutions.blogspot.com/
> http://www.youtube.com/user/GeoSolutionsIT
> http://www.linkedin.com/in/andreaaime
> http://twitter.com/geowolf
>
> -------------------------------------------------------
>
>
>
> ------------------------------------------------------------------------------
> Cloud Services Checklist: Pricing and Packaging Optimization
> This white paper is intended to serve as a reference, checklist and point
> of
> discussion for anyone considering optimizing the pricing and packaging
> model
> of a cloud services business. Read Now!
> http://www.accelacomm.com/jaw/sfnl/114/51491232/
> _______________________________________________
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Learn Windows Azure Live! Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for
developers. It will provide a great way to learn Windows Azure and what it
provides. You can attend the event by watching it streamed LIVE online.
Learn more at http://p.sf.net/sfu/ms-windowsazure
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel