On Mon, Mar 5, 2012 at 9:50 AM, Andrea Aime <[email protected]>wrote:
> On Mon, Mar 5, 2012 at 5:39 PM, Gabriel Roldan <[email protected]>wrote:
>
>> how about your decorator being a dynamic proxy that implements all the
>> interfaces the decorated object implements, and delegates to the proxy
>> object method except for the ones you want to override?
>>
>>
> That was my first thought as well, but there are catches:
> - JDBCDataStore is not an interface, so java own dynamic proxies are game
> over
> - JDBCDataStore is a final class, I believe that also kills any approach
> using
> bytecode engineered proxies
>
> If we have a IJDBCDataStore (sorry for the ugly name) that is a mixin
> interface,
> listing all the methods that a JDBCDataStore can have, then I guess we can
> following the first approach.
>
> I was hoping Justin would chime in, I know the topic of macking
> JDBCDataStore
> non final was raised before, and he did not like the idea
>
> Indeed, this was done pretty explicitly due to the mess of subclassing
that was the old jdbc datastores. We wanted to avoid subclassing at all
cost and instead use the dialog for all the customization. That said, I can
see how making the class final is limiting.
I would be ok with making JDBCDataStore an interface, or perhaps factoring
out a new interface like IJDBCDataStore or something, as long as we keep
the class final.
> Cheers
> Andrea
>
> --
> -------------------------------------------------------
> Ing. Andrea Aime
> GeoSolutions S.A.S.
> Tech lead
>
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
>
> phone: +39 0584 962313
> fax: +39 0584 962313
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://geo-solutions.blogspot.com/
> http://www.youtube.com/user/GeoSolutionsIT
> http://www.linkedin.com/in/andreaaime
> http://twitter.com/geowolf
>
> -------------------------------------------------------
>
>
> ------------------------------------------------------------------------------
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> Geoserver-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
