Hi all.
I'm looking over the findbugs reports for the main module (we ran into some
snags integrating it into the nightly build but Justin is helping me
investigate; in the meantime I am just looking over the unfiltered results
locally.) There seem to be some flagged sections in the catalog. From
initial review they look like real bugs, but in fixing them I have found
that the tests appear to be buggy as well[1]. It would help if I had some
specs on what guarantees the catalog is expected to enforce, but after
looking at the code/javadocs and the developer's manual I haven't found it.
If such a document exists, where can I find it? If not, how can we figure
out what the expected validation rules are supposed to be? I could review
the existing validations in CatalogImpl so we can start with a document
describing what's there right now.
[1]: For example, CatalogImplTest::testAddLayer tests adding a layer
without a name, then adding a layer without a resource. It is apparently
supposed to test the no-name validation by creating a layer and immediately
saving it (ie, the layer is invalid in more ways than just lacking a name.)
Then it adds a name and tests that layers without a resource should fail
validation - but the operation to add the name is commented out, meaning
that the no-name validation is just tested again.
--
David Winslow
OpenGeo - http://opengeo.org/
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
