On Fri, May 4, 2012 at 12:44 AM, Justin Deoliveira <[email protected]>wrote:
> Hi Nuno,
>
> No problem about the misformatting, it is a very common thing for people
> contributing initial patches. The new patch looks much nicer, thanks!
>
> So, its looking good for the most part. Although it looks like 3d is only
> respected if the 2d hint is specified to be false. I think it should be
> respected if the 2d hint is false, or the 2d hint is not specified at all.
>
> Also one thing is that we need to deprecate the old
> SQLDialect.encodeColumnName method, and probably have the implementation
> call through to the new one.
>
> As for the test i think it looks good, although with the behavior i
> mentioned above about interpreting the 2d hint it should no longer be
> necessary to override any of hte test methods in Postgis3D test.
>
Hum,
the original intended behavior for the hint was to return 3D geometries any
time the hint was not explicitly
set, that's how we got 3d geometries in GML and KML output even if those do
not explicitly set any hints,
while on the other side the renderer manually forces the hint in.
Do you know of other code paths, besides the renderer, that would break
when facing 3D data?
Cheers
Andrea
--
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 339 8844549
http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
