Cool, Implementation-Version is fine, change pushed.

On Wed, Aug 1, 2012 at 10:42 AM, Gabriel Roldan <[email protected]> wrote:

> On Wed, Aug 1, 2012 at 11:25 AM, Justin Deoliveira <[email protected]>
> wrote:
> > For the gwc revision issue it looks like the jar doesn't have
> Git-Revision
> > in the manifest, but does have Implementation-Version.
> >
> > @Gabriel: Can you confirm Implementation-Version is what we should be
> using?
> >
> > As for the git branch being equal to the revision not sure, i don't see
> that
> > locally. My guess is that the build is being run from a detached head?
>
> Sorry, I thought we've agreed that Imlementation-Version was to hold
> the git commit id, so I removed Git-Revision in favor of that one so
> that there's no conflict with the geotools entry.
> There's no entry for the originating branch name, although I could add
> it. For instance, it is the 'stable' branch.
>
> Let me know how you want to proceed. My preference is to keep on using
> Implementation-Version for the commit id, but can make it otherwise.
> And can also add the branch name and any other needed info.
>
> Cheers,
> Gabriel
> >
> >
> > On Tue, Jul 31, 2012 at 8:06 PM, Ben Caradoc-Davies
> > <[email protected]> wrote:
> >>
> >> And confirmed in a local build.
> >>
> >>
> >> On 01/08/12 10:04, Ben Caradoc-Davies wrote:
> >>>
> >>> I am now seeing an uninterpolated ${gwc.Git-Revision} in
> >>> target/VERSION.txt.
> >>>
> >>> And should that git branch be "master"?
> >>>
> >>> See:
> >>> http://files.ivec.org/geoserver/geoserver-master/2012-08-01/
> >>>
> http://files.ivec.org/geoserver/geoserver-master/2012-08-01/VERSION.txt
> >>>
> >>> version = 2.3-SNAPSHOT
> >>> git revision = d0d7f740e47dc4f84efc7f194bc8ef71fcd9e8d5
> >>> git branch = d0d7f740e47dc4f84efc7f194bc8ef71fcd9e8d5
> >>> build date = 20120801-0057
> >>> geotools version = 9-SNAPSHOT
> >>> geotools revision = e88fea56db8a4d50ccfca27fae9d72004938712b
> >>> geowebcache version = 1.3-SNAPSHOT
> >>> geowebcache revision = ${gwc.Git-Revision}
> >>> hudson build = -1
> >>>
> >>> That one is built on Jenkins:
> >>> https://cgsrv8.arrc.csiro.au/jenkins/view/geoserver-master/
> >>>
> >>> Kin regards,
> >>>
> >>
> >> --
> >> Ben Caradoc-Davies <[email protected]>
> >> Software Engineer
> >> CSIRO Earth Science and Resource Engineering
> >> Australian Resources Research Centre
> >>
> >>
> >
> >
> >
> > --
> > Justin Deoliveira
> > OpenGeo - http://opengeo.org
> > Enterprise support for open source geospatial.
> >
>
>
>
> --
> Gabriel Roldan
> OpenGeo - http://opengeo.org
> Expert service straight from the developers.
>



-- 
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to