Cool, will try to add this in when i get a few spare cycles.
On Thu, Aug 2, 2012 at 9:32 AM, Gabriel Roldan <[email protected]> wrote:
> your embedded tomcat patch looks nice indeed. Would be good to have.
>
> The servlet-api dependency is ugly though. But yeah, servlet
> containers are supposed to handle it. Just not sure why the maven
> tomcat plugin doesn't. You're right changing it to provided would
> affect downstream projects that require the servlet api (potentially
> suite and geonode?). IMHO it would be worth it at least on master, but
> not a strong position.
>
> The feeling of the webapp having to have jar packaging instead of war
> is on my mind too, just can't pull it up and remember what was is. Was
> hoping some of you may know whether it was an issue back when web-app
> contributed a bunch of classes (filters and the like) or it still is
> an issue.
>
> Looking forward for your patch to land though as it'll make things
> just much easier.
>
> Cheers,
> Gabriel
> On Thu, Aug 2, 2012 at 12:07 PM, Justin Deoliveira <[email protected]>
> wrote:
> > I can't remember exactly what it was but there was some issue i had
> before
> > when i tried to change the packaging of the web-app module to war from
> jar.
> > I can't remember what exactly it was. I also believe that change affects
> > downstream projects as well that depend on the web-app. MOstly for
> pulling
> > it its transitive dependencies.
> >
> > Somewhat related is something i played around with before in this thread.
> >
> >
> >
> http://geoserver-devel.821594.n3.nabble.com/Geoserver-devel-embedded-tomcat-td3188937.html
> >
> > Which instead of running from maven running from eclipse like most folks
> do
> > with jetty.
> >
> > On Thu, Aug 2, 2012 at 8:51 AM, Gabriel Roldan <[email protected]>
> wrote:
> >>
> >> Hi all,
> >>
> >> I had to debug a bug that happened on tomcat but didn't on jetty.
> >> To do so I wanted to figure out what would it take to being able of
> >> running mvn tomcat:run the same way to can do mvn jetty:run.
> >> It turns out that the embedded tomcat doesn't like our servlet-api
> >> dependency, which makes sense. Getting rid of it implies setting it to
> >> 'provided' scope, which in turn requires to explicitly add it to every
> >> pom that needs the Servlet API.
> >> The other think the tomcat maven plugin doesn't like is the web-app
> >> pom to have 'jar' packaging instead of 'war'. Now, since web-app moved
> >> to be pretty much just a web app with no code some time ago, I wonder
> >> if we could set its packaging to war. There are no classes ending up
> >> in WEB-INF/classes anyway so it doesn't make sense to have it as a
> >> jar?
> >>
> >> In any case, the following patch makes it so that mvn tomcat:run can
> >> be used. Review and comments appreciated.
> >>
> >> <
> https://github.com/groldan/geoserver/commit/d79a5f2a95cef80dda59fd283857e64136ee8b67
> >
> >>
> >> Cheers,
> >> Gabriel
> >> --
> >> Gabriel Roldan
> >> OpenGeo - http://opengeo.org
> >> Expert service straight from the developers.
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> Live Security Virtual Conference
> >> Exclusive live event will cover all the ways today's security and
> >> threat landscape has changed and how IT managers can respond.
> Discussions
> >> will include endpoint security, mobile security and the latest in
> malware
> >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >> _______________________________________________
> >> Geoserver-devel mailing list
> >> [email protected]
> >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
> >
> >
> >
> >
> > --
> > Justin Deoliveira
> > OpenGeo - http://opengeo.org
> > Enterprise support for open source geospatial.
> >
>
>
>
> --
> Gabriel Roldan
> OpenGeo - http://opengeo.org
> Expert service straight from the developers.
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
