Jody,
I have a workaround in final testing.
I am not sure why, but it seems that Andrea's changes in
4615daa694a5d84e4270a89f78cf8cc4a58a5206 as a side-effect appear to turn
on CITE compliance for this test. (And only this test? Why?)
The symptom is that in the test fixture a WFS request to a WFS service
URL fails if it has a VERSION but no SERVICE parameter. For example,
this silently fails:
getAsDOM("wfs?&version=1.1.0&request=GetFeature ...
This succeeds:
getAsDOM("wfs?service=WFS&version=1.1.0&request=GetFeature ...
My workaround is to add the SERVICE parameter for this test.
Andrea, can you see how your changes might have caused this behaviour? I
think there might have been an oversight in the way the dispatcher is
invoked by spring. I tried commenting out your Dispatcher changes but
that did not help. Please check as it might cause other unintended changes.
Here is the commit that seems to be related:
******
commit 4615daa694a5d84e4270a89f78cf8cc4a58a5206
Author: Andrea Aime <[email protected]>
Date: Sun Sep 16 16:57:37 2012 +0200
Making CSW GetCapabilities and DescribeRecord CITE compliant
******
Mostly CSW, but it also changes these:
src/main/src/main/java/org/geoserver/ows/CiteComplianceHack.java
src/main/src/test/java/applicationContext.xml
src/ows/src/main/java/org/geoserver/ows/Dispatcher.java
src/wfs/src/main/java/applicationContext.xml
src/wfs/src/main/java/org/geoserver/wfs/CiteComplianceHack.java
At least it looks like a spring problem, not an unfixable jxpath
problem. :-)
Kind regards,
Ben.
On 18/09/12 10:49, Ben Caradoc-Davies wrote:
> It looks like the failures started when Andrea and Alessio made a bunch
> of CSW changes.
>
> git diff db351e333fec5047bb2^ c03ce370f3a8da00
>
> I am investigating. I hope it isn't the jxpath crosstalk between
> unrelated modules I warned Andrea about last night ...
>
> On 18/09/12 09:25, Jody Garnett wrote:
>> The test results are here:
>> - http://hudson.opengeo.org/hudson/job/geoserver-master/5462/console
>> -
>> http://hudson.opengeo.org/hudson/job/geoserver-master/ws/src/extension/app-schema/app-schema-test/target/surefire-reports/org.geoserver.test.PropertySelectionTest.txt
>>
>> Example:
>>
>> junit.framework.AssertionFailedError: expected:<1> but was:<0>
>> at junit.framework.Assert.fail(Assert.java:47)
>> at junit.framework.Assert.failNotEquals(Assert.java:280)
>> at junit.framework.Assert.assertEquals(Assert.java:64)
>> at junit.framework.Assert.assertEquals(Assert.java:198)
>> at junit.framework.Assert.assertEquals(Assert.java:204)
>> at
>> org.geoserver.test.AbstractAppSchemaWfsTestSupport.assertXpathCount(AbstractAppSchemaWfsTestSupport.java:350)
>> at
>> org.geoserver.test.PropertySelectionTest.testGetFeature(PropertySelectionTest.java:44)
>>
>> --
>> Jody Garnett
>>
>
--
Ben Caradoc-Davies <[email protected]>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
