On Mon, Nov 5, 2012 at 8:53 PM, Andrea Aime <[email protected]>wrote:
> On Mon, Nov 5, 2012 at 3:29 PM, Justin Deoliveira <[email protected]>
> wrote:
> > So... back to how to fix. I still think not clearing the listener list on
> > disposal is probably simplest. By doing this though in order to avoid
> > duplicate listeners we probably want ResourcePool to first remove any
> > existing listeners. What about adding a method to Catalog to remove
> > listeners by type. So the resource pool constructor would become:
> >
> > catalog.removeListener(CacheClearingListener.class);
> > catalog.addListener(new CacheClearingListener());
>
> I like this one, I'll try to give it a shot
>
Here is a pull request:
https://github.com/geoserver/geoserver/pull/60
I first tried what you proposed, but that did not work because the resource
pool listener is attached to the new catalog, which does not have the old
listener, and similar troubles were present with the geoserver persister.
So I ended up doing a "cleanup, save and reattache" in the portion of the
code handling the catalog synch in the GeoServerLoader instead.
This seems cleaner and better centralized.
Can you review this one?
I've also created a jira and marked this bug as a blocker for 2.2 since
well...
once you do a reload you're pretty must toast, significant portions
of GeoServer stop working (no wonder we got all these vague reports
that the embedded GWC is not working, it's hard to associate a catalog
reload to the fact that GWC integration goes bye bye, especially since
quite likely people will notice the GWC issues long after the reload
has been done).
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
