The patch looks good to me. The forward and backward migration issues are well-thought-out. However, I am not sure where this change stands with respect to API stability.
The stable branch is meant to have a stable API. Because this change adds extra methods to LayerGroupInfo, if I have a third-party plugin that modifies the catalog and adds a new LayerGroupInfo implementation, it will be broken by this change because the third-party class does not implement the new methods. See the changes required to DecoratingLayerGroupInfo, for example. What do we consider to be the public API? Adding methods to a public interface will break third-party implementations. But perhaps the catalog is seen is internal to GeoServer? Kind regards, Ben. On 04/12/12 17:04, Andrea Aime wrote: > Hi, > this is a call for vote in order to backport to the stable branch the > "Title and abstract for layer groups" > feature landed on trunk some weeks ago via this pull request: > https://github.com/geoserver/geoserver/pull/52/ > > This backport fixes these two issues: > http://jira.codehaus.org/browse/GEOS-4142 > http://jira.codehaus.org/browse/GEOS-5325 > > It is a configuration change handled the usual way on the stable branch: > the two new attributes > are stored in the metadata map, to avoid breaking eventual people trying > 2.2.3 and then > deciding to go back to 2.2.2, whilst the code on trunk checks both > fields and metadata map. > > Davide also took care of preserving backwards compatibility in terms of > WMS capabilities > output, if the title is not explicitly set the code will use the layer > name like it did before. > > The patch seems clean and well tested to me, +1 on the backport. > > Cheers > Andrea > > -- > == > Our support, Your Success! Visit http://opensdi.geo-solutions.it for > more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions S.A.S. > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > mob: +39 339 8844549 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > -- Ben Caradoc-Davies <[email protected]> Software Engineer CSIRO Earth Science and Resource Engineering Australian Resources Research Centre ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
