Hey Christian,
To round this thread out, I am +1 on the proposal. However, I don't think
it should be backported to the stable branch, mostly due to the
configuration migration that is needed. I think it is good practice to
require a new minor version change for that.
This will also give the change some time to settle on master.
-Justin
On Tue, Nov 20, 2012 at 8:18 AM, Christian Mueller <[email protected]>wrote:
> Justin, your comments are already applied.
>
> There are minor changes in the security/filter directory.
>
> - adding the new role filter (passing back the roles in an HTTP header
> attribute)
> - The logout filter has an additional field "redirectURL"
>
> The major changes are in the config file for the security manager itself.
> The chains are stored in this file.
>
> Thanks for remembering me about the documentation about migration. I will
> modify the migration slightly to give users the chance to revert back.
> (renaming modified *.xml files to *.xml.2.2.0) and document this.
>
> Cheers
>
>
> 2012/11/20 Justin Deoliveira <[email protected]>
>
>> Thanks for putting this together Christian, definitely a good improvement
>> since as you point out the security filter stuff is still a bit strange to
>> configure. A couple of questions / comments.
>>
>> Minor: I made some comments on some trivial patch cleanup, not sure if
>> those got addressed.
>>
>> And the question is how does this affect the configuration stored on disk
>> under the security/filter directory? Like for constant filter chains do we
>> still have a configuration for it stored on disk? It would be good to get a
>> picture of that.
>>
>> Also, since this is a change to configuration it should also be
>> documented in the user guide for folks who will eventually upgrade to
>> whatever version this makes it into.
>>
>> http://docs.geoserver.org/stable/en/user/datadirectory/migrating.html
>>
>> On Fri, Nov 16, 2012 at 3:08 AM, Alessio Fabiani <
>> [email protected]> wrote:
>>
>>> +0
>>>
>>> ==
>>> Our support, Your Success! Visit http://opensdi.geo-solutions.it for
>>> more information.
>>> ==
>>>
>>> Ing. Alessio Fabiani
>>> @alfa7691
>>> Founder/Technical Lead
>>>
>>> GeoSolutions S.A.S.
>>> Via Poggio alle Viti 1187
>>> 55054 Massarosa (LU)
>>> Italy
>>> phone: +39 0584 962313
>>> fax: +39 0584 1660272
>>> mob: +39 331 6233686
>>>
>>> http://www.geo-solutions.it
>>> http://twitter.com/geosolutions_it
>>>
>>> -------------------------------------------------------
>>>
>>>
>>>
>>> On Wed, Nov 14, 2012 at 4:42 PM, Christian Mueller
>>> <[email protected]>wrote:
>>>
>>>> Please vote on
>>>>
>>>>
>>>> http://geoserver.org/display/GEOS/GSIP+82+-+Reworking+security+filter+chains
>>>>
>>>> Thanks to all
>>>> Christian
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Monitor your physical, virtual and cloud infrastructure from a single
>>>> web console. Get in-depth insight into apps, servers, databases, vmware,
>>>> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>>>> Pricing starts from $795 for 25 servers or applications!
>>>> http://p.sf.net/sfu/zoho_dev2dev_nov
>>>> _______________________________________________
>>>> Geoserver-devel mailing list
>>>> [email protected]
>>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>>>
>>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Monitor your physical, virtual and cloud infrastructure from a single
>>> web console. Get in-depth insight into apps, servers, databases, vmware,
>>> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>>> Pricing starts from $795 for 25 servers or applications!
>>> http://p.sf.net/sfu/zoho_dev2dev_nov
>>> _______________________________________________
>>> Geoserver-devel mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>>
>>>
>>
>>
>> --
>> Justin Deoliveira
>> OpenGeo - http://opengeo.org
>> Enterprise support for open source geospatial.
>>
>>
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
