Looks good to me. If I were to add a couple of things.
* rename endpoint /about/resources to /about/manifest, seems a bit more
explicit about what it is returning
* rename "ManifestLoader.properties" to just "manifest.properties". More
inline with existing naming conventions and since its a user visible file
(ie. it lives in the data directory) it would be nice if it were in a more
"readable" format, rather than in Java camel case style.
Just suggestions, both non blocking.
On Thu, Dec 20, 2012 at 9:56 AM, Alessio Fabiani <
alessio.fabi...@geo-solutions.it> wrote:
> I should alreay voted for this gsip, however just in case ... +1
>
>
> ==
> Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
> information.
> ==
>
> Ing. Alessio Fabiani
> @alfa7691
> Founder/Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 331 6233686
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
>
>
> On Thu, Dec 20, 2012 at 3:15 PM, Carlo Cancellieri <
> ccancelli...@hotmail.com> wrote:
>
>> Hi all,
>> here is the pull request:
>> https://github.com/geoserver/geoserver/pull/85
>>
>> Still missing documentation, I'm waiting for your votes.
>> Cheers,
>> Carlo Cancellieri - GeoSolutions SAS
>>
>> ------------------------------
>> From: ccancelli...@hotmail.com
>> To: andrea.a...@geo-solutions.it
>> Date: Wed, 19 Dec 2012 09:50:06 +0000
>> CC: geoserver-devel@lists.sourceforge.net
>> Subject: Re: [Geoserver-devel] GSIP 83 - REST Extensible and customizable
>> versions report
>>
>> Andrea,
>> thank you for feedback.
>>
>> > - following up the usual GeoServer REST conventions, in
>> > /rest/about/resources.format the format should be optional and the
>> default
>> > should be HTML (the proposal does not say which formats are supported
>> btw)
>>
>> Added HTML support and modified proposal here:
>>
>> http://geoserver.org/pages/viewpage.action?pageId=55574531#GSIP83-RESTExtensibleandcustomizableversionsreport%E2%80%8F-Supportedformats%3A<http://geoserver.org/pages/viewpage.action?pageId=55574531#GSIP83-RESTExtensibleandcustomizableversionsreport%E2%80%8F-Supportedformats:>
>>
>>
>> Carlo Cancellieri - GeoSolutions SAS
>>
>> --
>> ==
>> Our support, Your Success! Visit http://opensdi.geo-solutions.it for
>> more information.
>> ==
>>
>> GeoSolutions S.A.S.
>> Via Poggio alle Viti 1187
>> 55054 Massarosa (LU)
>> Italy
>> phone: +39 0584 962313
>> fax: +39 0584 1660272
>>
>> http://www.geo-solutions.it
>> http://twitter.com/geosolutions_it
>>
>> -------------------------------------------------------
>>
>>
>> ------------------------------------------------------------------------------
>> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
>> Remotely access PCs and mobile devices and provide instant support Improve
>> your efficiency, and focus on delivering more value-add services Discover
>> what IT Professionals Know. Rescue delivers
>> http://p.sf.net/sfu/logmein_12329d2d
>> _______________________________________________ Geoserver-devel mailing
>> list Geoserver-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>
>>
>> ------------------------------------------------------------------------------
>> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
>> Remotely access PCs and mobile devices and provide instant support
>> Improve your efficiency, and focus on delivering more value-add services
>> Discover what IT Professionals Know. Rescue delivers
>> http://p.sf.net/sfu/logmein_12329d2d
>> _______________________________________________
>> Geoserver-devel mailing list
>> Geoserver-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>
>>
>
>
> ------------------------------------------------------------------------------
> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
> Remotely access PCs and mobile devices and provide instant support
> Improve your efficiency, and focus on delivering more value-add services
> Discover what IT Professionals Know. Rescue delivers
> http://p.sf.net/sfu/logmein_12329d2d
> _______________________________________________
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and
much more. Get web development skills now with LearnDevNow -
350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122812
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
