Hey Yancy,
Adding to Jody's comments I to think this makes more sense as a GeoTools
pull request. The only parts that need to remain in GeoServer could be the
profile that engates the dependency.
Also, I suggest you follow the packaging naming convention of
org.geotools.gce.netcdf.
-Justin
On Wed, Mar 13, 2013 at 5:31 PM, Yancy Matherne
<[email protected]>wrote:
> Thanks for the feedback. We can certainly make those changes. We were
> trying to keep things simpler by having everything in one place. The
> NetCDFFormat can be moved to geotools if that is appropriate, the licenses
> do not matter to us. We actually have more test data but the files are
> unfortunately pretty big. We are going to try to get some more test files
> that are slices of the big data.
>
>
>
>
> Thanks,
> Yancy Matherne
> Software Developer
>
> Geocent, LLC
> 111 Veterans Blvd., Suite 1600
> Metairie, LA 70005
> O: (504) 831-1900
> E: [email protected]
> http://www.geocent.com
> ------------------------------
> *From:* Jody Garnett [[email protected]]
> *Sent:* Wednesday, March 13, 2013 6:11 PM
> *To:* Yancy Matherne
> *Cc:* [email protected]
> *Subject:* Re: [Geoserver-devel] NetCDF Plugin
>
> A couple small things:
>
> You have added the following to your community/netcdf/pom.xml
>
> <netcdf.version>4.2-min</netcdf.version>
> <joda-time.version>1.5.2</joda-time.version>
>
> Can we take those version numbers up to the root pom.xml in the
> dependency management section, that way we have one place to manage
> "version hell" for the project (which will help if two modules need
> joda-time for example).
>
> As for netcdf/src/main/java/org/geocent/geotools/NetCDFFormat.java … is
> there a reason this is not in the geotools library? Well other than GPL
> license …
>
> Other than that some non useful feedback on style:
> - If you can try for a class javadoc it helps those using an IDE
> - NearestNeighbor implements IndexingStrategy .. we tend to use the
> interface in the naming so the code reads well:
> NearestNeighborIndexingStrategy
>
> It is great that you have sample data in support of tests, can you make
> a note of where the sample data comes from? Say in your README.txt.
>
> Cheers
> --
> Jody Garnett
>
> On Thursday, 14 March 2013 at 8:36 AM, Yancy Matherne wrote:
>
> Hi all,
>
> I have our NetCDF plugin up on my GitHub now:
> https://github.com/geocent-yancy/geoserver/tree/netcdf
>
> We'd appreciate it if you could take a look before I make a pull
> request. We realize it still has a ways to go before it is a general
> purpose NetCDF plugin. But we would like to start getting some more eyes on
> it.
>
>
>
> Thanks,
> Yancy Matherne
> Software Developer
>
> Geocent, LLC
> 111 Veterans Blvd., Suite 1600
> Metairie, LA 70005
> O: (504) 831-1900
> E: [email protected]
> http://www.geocent.com
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_mar
> _______________________________________________
> Geoserver-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
>
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_mar
> _______________________________________________
> Geoserver-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
