On Thu, May 9, 2013 at 11:01 AM, Mauro Bartolomeoli <
[email protected]> wrote:
>
>
>
> 2013/4/30 Justin Deoliveira <[email protected]>
>
>> Hi Mauro,
>>
>> Sorry for the late reply on this. The approach sounds good to me. A
>> couple of thoughts and suggestions.
>>
>> Perhaps it makes sense to have a separate "ActiveDirectory" provider,
>> rather than overload the default ldap one with more options. Just a
>> suggestion, not sure how much of the existing provider is used in this
>> scheme.
>>
>> Regardless of one or more providers, it would be good if we could update
>> the docs along with this patch. The relevant page being:
>>
>>
>> http://docs.geoserver.org/stable/en/user/security/auth/providers.html#ldap-authentication
>>
>> -Justin
>>
>>
> Hi Justin and all,
> I prepared a pull request for this:
> https://github.com/geoserver/geoserver/pull/232
> If someone would like to have a look at it before merging, it would be
> awesome.
>
> Nice work! I just looked over the pull request and it looks good to me.
Nice improvements.
> I added some tests: tests were missing completely in the security ldap
> module, so I needed to add a dependency to spring-ldap-test (with scope
> test) to have a mock ldap server.
> For the moment I added tests only for the new features added with this
> request.
> I also updated the docs a little bit to explain the new options and
> illustrate how to connect to an ActiveDirectory server.
>
Awesome. Indeed i never got around to figuring out how to setup spring for
testing with ads. Thanks for doing that.
>
> Thanks
> Mauro Bartolomeoli
>
> --
> ==
> GeoServer training in Milan, 6th & 7th June 2013! Visit
> http://geoserver.geo-solutions.it for more information.
> ==
>
> Dott. Mauro Bartolomeoli
> @mauro_bart
> Senior Software Engineer
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and
their applications. This 200-page book is written by three acclaimed
leaders in the field. The early access version is available now.
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
