On Thu, Jul 25, 2013 at 9:19 AM, Daniele Romagnoli <
[email protected]> wrote:

> Hi Andrea,
> please, read below...
>
>
>
> On Wed, Jul 24, 2013 at 7:03 PM, Andrea Aime <[email protected]
> > wrote:
>
>> On Wed, Jul 24, 2013 at 6:52 PM, Daniele Romagnoli <
>> [email protected]> wrote:
>>
>>> Hi guys,
>>> I didn't receive any feedback on this.
>>> I have encountered again the issue on windows which converts my
>>> "pgraster://" string into a "pgraster:\ file" which let fail my URL parsing
>>> code.
>>> I would like to do something like this on that utility method.
>>> The last else in GeoserverDataDirectory.findDataFileFile simply returns
>>> new File(path).
>>>
>>> I would do instead something like this:
>>> File file = new File(path);
>>> if (file.exists()) {
>>>    return file;
>>> }
>>> return null;
>>>
>>
>> Where do you see that?
>>
>
> On ResourcePool class, the getGridCoverageReader method tries to get a
> File in case the reader is null, by invoking
> GeoserverDataDirectory.findDataFile();
>
> https://github.com/geoserver/geoserver/blob/master/src/main/src/main/java/org/geoserver/catalog/ResourcePool.java#L1244
>
> findDataFile (
> https://github.com/geoserver/geoserver/blob/master/src/main/src/main/java/org/vfny/geoserver/global/GeoserverDataDirectory.java#L210
> )
> return a newFile as last "else" statement:
>
> https://github.com/geoserver/geoserver/blob/master/src/main/src/main/java/org/vfny/geoserver/global/GeoserverDataDirectory.java#L242
>

Doh, I went down the wrong path.
Yeah, I believe what you're suggesting makes sense. The code should not
really be tied only to file system paths,
grid coverages  can come from remote services too. (postgis, oracle, remote
wcs and so on)

Cheers
Andrea

-- 
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to