On Wed, Nov 27, 2013 at 6:41 AM, Jody Garnett <jody.garn...@gmail.com>wrote:
> This feedback may be over kill for an internal refactoring, but I find the
> number of parameters hanging off the identify method to be awkward.
>
> You already have one "param object" in FeatureInfoRequestParameters -
> excellent move as WMS specification will change over time.
>
> Should layer, style, filter, maxFeatures (which all seem to provide some
> context) be handled the same way under to allow growth in the future
> without breaking API?
>
Good idea, I've updated the pull request to follow.
The only thing that was left explicit is maxFeatures, since it's controlled
and updated as we move
from one layer to the next by the main GetFeatureInfo class.
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
