Seems like a good fix for me. +1 on backport.

On Wed, Dec 4, 2013 at 9:47 AM, Andrea Aime <[email protected]>wrote:

> Hi,
> I've just made an improvement to ResourcePool that lowers the cost of using
> sql views, which at the current time problematic especially on Oracle.
>
> Basically, the old code was creating a new random sqlview to get its
> feature type every time
> the requested feature type was not cacheable (which happens for every data
> access
> request, due to the way we handle projection policies).
> The modification is simple, if the virtual table is already there we fetch
> its feature type
> directly instead of creating a new one with the same structure:
>
>
> https://github.com/geoserver/geoserver/commit/d37386c04062ff9afc7f4c8adb0f231381cd70d7
>
> Do you mind if I backport the same change to the stable series?
> I can't see drawbacks in the change, but an extra pair of eyes would not
> hurt.
>
> Cheers
> Andrea
>
> --
> ==
> Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
> information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054  Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39  339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
>
> ------------------------------------------------------------------------------
> Sponsored by Intel(R) XDK
> Develop, test and display web and hybrid apps with a single code base.
> Download it for free now!
>
> http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
> _______________________________________________
> Geoserver-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
>


-- 
*Justin Deoliveira*
Vice President, Engineering | Boundless
[email protected]
@j_deolive <https://twitter.com/j_deolive>
------------------------------------------------------------------------------
Sponsored by Intel(R) XDK 
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to