Hi,
I'm not a GeoServer developer, but I loiter around on the list and have a
ArcGIS install.
I quite like it though don't envision using it myself.
Have you considered making it a QGIS plugin? That's more in keeping with
the Open Source ethos (not that this isn't potentially useful) I imagine
your python scripts could be made fairly portable if you separate the logic
up.
Some thoughts below, mostly little feature enhancement things. Apologies
for the longish list; I didn't test everything but put down what I noticed.
1) The readme has a ".md" extension for some reason.
2) The readme doesn't say how to install it. I see that's online.
3) I wanted to install the script here: C:\GeoServer-ArcAdmin-1.0\
But it didn't work because the toolbox couldn't find the script - it seems
you've hardcoded the location that the toolbox is looking for the script.
If possible I'd strongly suggest making it look for relative locations
rather than absolute locations. Not everyone will be able to create a
directory in their C:\ drive with the applicable name.
4) When I got it installed and tried to use it, I received this error
(because it turns out my test server was turned off! :-) ):
> Running script newWorkspace...
> Traceback (most recent call last):
> File "C:\GeoServer ArcAdmin\workspaceOlustur.py", line 30, in <module>
> response = urllib2.urlopen(istek)
> File "D:\Python27\ArcGIS10.1\Lib\urllib2.py", line 126, in urlopen
> return _opener.open(url, data, timeout)
> File "D:\Python27\ArcGIS10.1\Lib\urllib2.py", line 394, in open
> response = self._open(req, data)
> File "D:\Python27\ArcGIS10.1\Lib\urllib2.py", line 412, in _open
> '_open', req)
> File "D:\Python27\ArcGIS10.1\Lib\urllib2.py", line 372, in _call_chain
> result = func(*args)
> File "D:\Python27\ArcGIS10.1\Lib\urllib2.py", line 1199, in http_open
> return self.do_open(httplib.HTTPConnection, req)
> File "D:\Python27\ArcGIS10.1\Lib\urllib2.py", line 1174, in do_open
> raise URLError(err)
> URLError: <urlopen error [Errno 10060] A connection attempt failed because
> the connected party did not properly respond after a period of time, or
> established connection failed because connected host has failed to respond>
> Failed to execute (newWorkspace).
>
- You may want to make the error messages more human-friendly if possible -
I understood the meaning, but others may not. Also you may wish to remove
the stacktrace for "obvious" errors like the server not responding so you
can make the error even more user friendly.
5) If possible, the tools remembering the URL/credentials entered
previously would be *really* useful. Ideally for all tools (so enter the
credentials in one tool, they get pre-filled-in in all tool). Having to
re-enter them every time would get very irksome very quickly. If you do
this, an option to enable or disable "saving" the password locally would be
an idea (some people may not wish it to be saved for security reasons,
others might).
6) Looking at the help for "Upload Compressed File" - it says "Shapefile
must be top of the ZIP archive." - I'm not clear what that actually means.
7) You may want to use * (asterisks) for the password to hide it.
And please, please, add comments to your Python code! :-) There are only 3
in the entire thing. Even if they are in Turkish(?) they'll help someone in
the future if they want to utilise it.
Hope that helps; as noted, it looks like quite a nice little tool,
especially for adding data to GeoServer.
Cheers,
Jonathan
--
This transmission is intended for the named addressee(s) only and may
contain sensitive or protectively marked material up to RESTRICTED and
should be handled accordingly. Unless you are the named addressee (or
authorised to receive it for the addressee) you may not copy or use it, or
disclose it to anyone else. If you have received this transmission in error
please notify the sender immediately. All email traffic sent to or from us,
including without limitation all GCSX traffic, may be subject to recording
and/or monitoring in accordance with relevant legislation.
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
