Hi Niels,
I did a quick check of the pull request and it seems good to me.
I have only a trivial feedback (not a major issue but...):
GT/GS use a coding convention which always requires braces on if condition,
even for a single line.
Could you please update:
if (condition)
dosomething;
with
if (condition) {
dosomething;
}
on your patch?
I know... it's a very silly note and probably some other old parts of the
code doesn't respect that but since we are here... :)
Beside of that it looks good to me.
Cheers,
Daniele
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Daniele Romagnoli
Senior Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
On Mon, Feb 10, 2014 at 2:30 PM, Niels Charlier <[email protected]> wrote:
> Hi,
>
> I made a patch a few months ago to support tiff files made by mapinfo:
> these are plain tiff files accompanied by a .tab file with metadata,
> written in a mapinfo specific format. I integrated this option in the
> geotiff reader.
> How it works: if there is no metadata in the tiff (so it is not geotiff)
> and there is also not a .wld file, it will as a third option check for a
> .tab file and support this (instead of rejecting it because of missing
> any metadata).
> In other words, this is additional support/functionality that does not
> affect any other functionality or API.
>
> I thought it might be interesting to have this available for everyone,
> so it would be nice if it were accepted in geoserver.
> See https://github.com/geotools/geotools/pull/321
> http://jira.codehaus.org/browse/GEOT-4619
>
> Kind Regards
> Niels
>
>
> ------------------------------------------------------------------------------
> Managing the Performance of Cloud-Based Applications
> Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
> Read the Whitepaper.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
> _______________________________________________
> Geoserver-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
