On Tue, Mar 4, 2014 at 9:29 AM, Andrea Aime <andrea.a...@geo-solutions.it>wrote:
> On Tue, Mar 4, 2014 at 5:25 PM, Justin Deoliveira <
> jdeol...@boundlessgeo.com> wrote:
>
>> On Tue, Mar 4, 2014 at 9:14 AM, Andrea Aime <andrea.a...@geo-solutions.it
>> > wrote:
>>
>>> On Tue, Mar 4, 2014 at 5:11 PM, Justin Deoliveira <
>>> jdeol...@boundlessgeo.com> wrote:
>>>
>>>> Yep, that would work also.
>>>>> It may not mix too well with CQL expression/variable expansion parsing
>>>>> though (e.g., we'd need escapes, or start/end markers).
>>>>>
>>>>> Some bright ideas on how to approach this? Trying to accept both
>>>>> suggestions at the same time seems to raise complexity
>>>>> quite a bit.
>>>>>
>>>>> Sorry, I think I missed something here. When did cql expansion come
>>>> into the picture? And what is the other suggestion you are referring to so
>>>> i am clear.
>>>>
>>>
>>> Ian Scheider one. in this same thread
>>>
>>> Ok... unless my email client is filtering out a message from ian the
>> only one i see is about using using java.net.InetAddress.getLocalHost()
>> as the default? I don't see a reference to cql.
>>
>
> It's something I did add, because having just a special case for the IP
> address seemed very narrow. My answer:
>
>
> -----------------------------------------------------------------------------------------------------------------
> Hmm... not sure we want to have this visible in every page unless the
> admin asks for it.
> But we could have maybe a fixed placeholder value for it:
> -DGEOSERVER_NODE_ID=$ip
> or extend the concept and have some variable expansion, like
> -DGEOSERVER_NODE_ID=mygs_$ip
>
> -----------------------------------------------------------------------------------------------------------------
>
> (and I was thinking cql when I wrote "variable expansion", but I see I did
> not write it!)
>
> But if we limit ourselves to simple variable expansion, then yeah, no cql
> is actually needed
>
>
>>
>> Would it make it easier if we had to two parameters?
>>
>> GEOSERVER_NODE_ID - the node id, following ians suggestion
>> GEOSERVER_NODE_OPTS - everything else, color, etc...
>>
>> And to clarify I was thinking everything in GEOSERVER_NODE_OPTS would
>> just be static.
>>
>
> Right, that would work as well.
> Or if we take Ian's suggestion to the letter, something like:
> -DGEOSERVER_NODE_OPTS=color:FF0000
> would be expanded to have the IP as the id (since that would be the
> default)
>
> That works for me too. I don't want to add complexity for you so whatever
you feel is reasonable go ahead with. The only thing I would push for would
would be to avoid adding specific properties for "display properties" like
color, etc... and rather have just single option for that stuff.
Cheers
> Andrea
>
>
> --
> == Our support, Your Success! Visit http://opensdi.geo-solutions.it for
> more information ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
--
*Justin Deoliveira*
Vice President, Engineering | Boundless
jdeol...@boundlessgeo.com
@j_deolive <https://twitter.com/j_deolive>
------------------------------------------------------------------------------
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works.
Faster operations. Version large binaries. Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
