On Fri, Apr 25, 2014 at 2:47 PM, Sampo Savolainen <
sampo.savolai...@spatineo.com> wrote:
> Generalizing this is definitely one way to go. I'm a bit wary of starting
>> doing that, especially since from the looks of it, the SQL view
>> implementation looks a bit iffy. See the third line you quoted:
>>
> if(dataStore instanceof JDBCDataStore && info.getMetadata() != null &&
>
> info.getMetadata().containsKey(FeatureTypeInfo.JDBC_VIRTUAL_TABLE)) {
> ...
>
> The dataStore object might already be wrapped! This means this code does
> not work in every case.
>
We don't wrap stores at the ResourcePool level, if we do, it's happening
higher level in the security
wrappers. ResourcePool gets the stores from the factories directly, there
are no intermediaries that
I'm aware of, just check the getDataStore code paths.
>
> What do you think about my later suggestion that we could add the metadata
> as a Query hint? I'm now prototyping it so that GeoServerFeatureSource is
> given the metadata map, which it then injects into Queries in
> getFeatures(). It looks promising from my point of view.
>
For it to work, the feature type must to exist already, and the wrapping
must not change it
(since query hints are provided only when accessing data, not when asking
for metadata).
I'd rather use a mechanism that is not making these assumptions, they make
the use
case pretty narrow.
I could go with it, if you can show the modification to support this case
are minimal.
I don't like it because no other store works that way, so we'd be left with
a special
case for virtual stores, plus one that is likely going to be used by wfs-ng
only.
Cheers
Andrea
--
==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
