On Thu, May 1, 2014 at 3:15 AM, Andrea Aime <andrea.a...@geo-solutions.it>wrote:

> On Wed, Apr 30, 2014 at 3:56 PM, Justin Deoliveira <
> jdeol...@boundlessgeo.com> wrote:
>
>> @Ben: Unfortunately i haven't time to investigate further due to being
>> swamped with project work. If someone has some spare cycles and could run
>> all the tests locally that would help, as that is my next step.
>>
>> But I did do a bit of investigation when things started breaking, here is
>> what I found. I manage to fix a couple of the tests on master because they
>> were still running with a version 6 jdk. I rebooted and reran all the other
>> tests and from what I could tell there were what appeared to be some
>> legitimate failures. For example, for WCS 1.0 to pass some of the tests
>> that require we throw exception on capabilities requests we have to remove
>> all the other wcs modules. That hack didn't seem to be working.
>>
>
> I've just tried WCS 1.0 tests, this time using the same bin package used
> for WFS (with xerces removed from the picture),
> and as you said I've removed the gs-wcs1_1 and gs-wcs2_0 jars from the
> picture in order to avoid issues with the
> wcs 1.0 caps cite tests (which are assuming the server does not implement
> higher versions of the protocol).
>
> I have a full pass, 114 tests passing.
> I'm wondering:
> - where is the code that's removing the higher versions of the wcs jars
> from the geoserver war? I don't see it in run.sh
>

It is in the individual data directories.

https://github.com/geoserver/geoserver/blob/master/data/citewcs-1.0/init.sh
https://github.com/geoserver/geoserver/blob/master/data/citewcs-1.1/init.sh

run.sh calls those scripts if they exist around line 56.


> - maybe the issue is caused by wcs 2.0 graduating to supported status, and
> the 2.0 jar not being removed before running the tests?
>

Makes sense... although it seems like those regex should remove it. I just
did a wcs 1.0 run and checked the contents of the WEB-INF/lib directory.

jenkins@ares:~/cite/geoserver/geoserver-2.6-SNAPSHOT/webapps/geoserver/WEB-INF/lib$
ls | grep wcs
gs-wcs1_0-2.6-SNAPSHOT.jar
gs-wcs-2.6-SNAPSHOT.jar
gt-xsd-wcs-12-SNAPSHOT.jar
net.opengis.wcs-12-SNAPSHOT.jar

And it looks like the right jars are removed... unless its something in the
common jar that now leads to the conflict?

>
> The WCS 1.1 tests are instead at least partly because wcs 2.0 is now in
> the classpath, going to have a look at it there
> are class cast exceptions when running:
>
>
> http://localhost:8080/geoserver/ows?service=WCS&request=GetCapabilities&sections=OperationsMetadata,Contents&ACCEPT_VERSIONS=1.1.1
>
> Caused by: java.lang.ClassCastException:
> net.opengis.ows11.impl.SectionsTypeImpl cannot be cast to
> net.opengis.ows20.SectionsType
> at
> net.opengis.ows20.impl.GetCapabilitiesTypeImpl.eSet(GetCapabilitiesTypeImpl.java:409)
>  at
> net.opengis.wcs20.impl.GetCapabilitiesTypeImpl.eSet(GetCapabilitiesTypeImpl.java:148)
> at
> org.eclipse.emf.ecore.impl.BasicEObjectImpl.eSet(BasicEObjectImpl.java:1081)
>
> I guess that in this case the version negotiation is not probably handled
> at the dispatcher level, since accept_versions is set
> it should try to parse the request as a 1.1.1 one, not as a 2.0 one.
>
> Just to see if there is anything else, I've removed the WCS 2.0 jar from
> GeoServer and re-run the CITE tests, getting a full pass.
>
> Cheers
> Andrea
>
> --
> ==
> Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
> for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054  Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39  339 8844549
>
> http://www.geo-solutions.it
>  http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>



-- 
*Justin Deoliveira*
Vice President, Engineering | Boundless
jdeol...@boundlessgeo.com
@j_deolive <https://twitter.com/j_deolive>
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to