Hmmm... not sure why it was done that way... maybe because WFS was the only
service that needed the cite compliance hacks to pass cite? Not sure. The
way it is implemented has other issues as well... it uses a field on the
dispatcher itself which totally has concurrency issues... truly a hack as
its name indicates :)
Perhaps we can do this. Instead of making the CiteComplianceHack class a
HandlerINterceptor let's make it a dispatcher callback. And let's remove
the citeCompliant field from the dispatcher and move it to the Request
class. Then the dispatcher callback can set it there.
On Thu, May 1, 2014 at 4:12 AM, Andrea Aime <andrea.a...@geo-solutions.it>wrote:
> Ah, actually this works also for CSW on the geoserver/csw path... but
> regardless... the way this works
> breaks when people use ows, as we cannot statically associate a service
> class to it...
>
> Cheers
> Andrea
>
>
> On Thu, May 1, 2014 at 12:11 PM, Andrea Aime <andrea.a...@geo-solutions.it
> > wrote:
>
>> Hi,
>> I was looking around and to my horror I've found that the cite compliance
>> field
>> gets set in the dispatcher only when using the wfs protocol and the
>> geoserver/wfs path:
>>
>> <bean id="wfsCiteComplianceHack"
>> class="org.geoserver.ows.CiteComplianceHack">
>> <constructor-arg ref="geoServer"/>
>> <constructor-arg value="org.geoserver.wfs.WFSInfo"/>
>> </bean>
>>
>>
>> <!-- http url mapping -->
>> <bean id="wfsURLMapping"
>> class="org.geoserver.ows.OWSHandlerMapping">
>> <constructor-arg ref="catalog"/>
>> <property name="alwaysUseFullPath" value="true"/>
>> <property name="interceptors">
>> <list>
>> <ref bean="wfsCiteComplianceHack"/>
>> <ref bean="xmlPostRequestLogBufferSize"/>
>> </list>
>> </property>
>> <property name="mappings">
>> <props>
>> *<prop key="/wfs">dispatcher</prop>*
>> * <prop key="/wfs/*">dispatcher</prop>*
>> * <prop key="/TestWfsPost">wfsTestServlet</prop>*
>> </props>
>> </property>
>> </bean>
>>
>> Blek... it means that all other service are not covered, and that when
>> using
>> ows not even wfs is.
>>
>> I guess that to have this work for all services a significant rework
>> would be
>> in order?
>>
>> Cheers
>> Andrea
>>
>> --
>> ==
>> Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
>> for more information.
>> ==
>>
>> Ing. Andrea Aime
>> @geowolf
>> Technical Lead
>>
>> GeoSolutions S.A.S.
>> Via Poggio alle Viti 1187
>> 55054 Massarosa (LU)
>> Italy
>> phone: +39 0584 962313
>> fax: +39 0584 1660272
>> mob: +39 339 8844549
>>
>> http://www.geo-solutions.it
>> http://twitter.com/geosolutions_it
>>
>> -------------------------------------------------------
>>
>
>
>
> --
> ==
> Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
> for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
>
> ------------------------------------------------------------------------------
> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
> Instantly run your Selenium tests across 300+ browser/OS combos. Get
> unparalleled scalability from the best Selenium testing platform available.
> Simple to use. Nothing to install. Get started now for free."
> http://p.sf.net/sfu/SauceLabs
> _______________________________________________
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
>
--
*Justin Deoliveira*
Vice President, Engineering | Boundless
jdeol...@boundlessgeo.com
@j_deolive <https://twitter.com/j_deolive>
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos. Get
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
