On Wed, May 14, 2014 at 5:25 AM, Jared Erickson <[email protected]>wrote:
> Hi all,
>
> Sorry for the delay, but I am the world’s slowest wicket developer. I
> finally have CodeMirror working as the editor for scripts (see attached).
> This required upgrading CodeMirror to version 4.1 (the latest) which
> supports all modern browsers and IE 8 and above (
> http://codemirror.net/#browsersupport). I have tested the upgraded
> CodeMirror on FireFox, Chrome, and Safari on OS X. I haven’t tested on IE
> yet. If these proposed changes seems acceptable how would you like me to
> structure the pull requests? I see two alternatives:
>
> #1
> 1. CodeMirror Upgrade
> 2. Script UI using CodeMirror
>
> #2.
> 1. Script UI using text area
> 2. CodeMirror Upgrade
> 3. Script UI using CodeMirror
>
> The only reason to go with #2 is if the CodeMirror upgrade is problematic.
>
The only reason for concern is that, I believe, the version we're currently
using supports IE down to version 6 (support for which was dropped around
2012).
I guess it would be nice/useful if the code could recognize the browser
version and fall back on a plain text area in case the
browser is not supported.
Maybe you go with 2, make the pull request for the code mirror upgrade, and
allow other people to help you with the above?
Cheers
Andrea
--
==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
