Hi Christian,
merge done.
Thank you very much.
Regards,
Mauro Bartolomeoli
2014-07-11 11:47 GMT+02:00 Christian Mueller <
christian.muel...@os-solutions.at>:
> Hi Mauro
>
> Your thoughts are correct. Adding the if in the get method will do the job.
>
> After adding the if, you can merge.
>
> Cheers
> Christian
>
>
> On Fri, Jul 11, 2014 at 11:28 AM, Mauro Bartolomeoli <
> mauro.bartolome...@geo-solutions.it> wrote:
>
>> Hi Christian,
>> I thought a bit more about this.
>>
>> If I understood correctly, the issue is that when the entry timeout is
>> shorter than the cache timeout, the entry is considered valid, because the
>> cache is trusted to return "not expired" values only, while in the opposite
>> case (netry timeout longer than cache timeout) there is no problem,
>> because if the cache returns null for an entry, the digest is checked from
>> the request headers again. Is this correct?
>>
>> If this is the only problematic use case, we can probably simply add back
>> the check for the entry expiration in the get method:
>>
>>
>>
>> if (entry.hasExpired(currentTime)) {
>>
>> return null;
>> }
>>
>>
>>
>>
>> What do you think? Is this enough for now?
>>
>> Thanks
>> Mauro
>>
>>
>> --
>> ==
>> GeoServer Professional Services from the experts! Visit
>> http://goo.gl/NWWaa2 for more information.
>> ==
>>
>> Dott. Mauro Bartolomeoli
>> @mauro_bart
>> Senior Software Engineer
>>
>> GeoSolutions S.A.S.
>> Via Poggio alle Viti 1187
>> 55054 Massarosa (LU)
>> Italy
>> phone: +39 0584 962313
>> fax: +39 0584 1660272
>>
>> http://www.geo-solutions.it
>> http://twitter.com/geosolutions_it
>>
>> -------------------------------------------------------
>>
>
>
>
> --
> DI Christian Mueller MSc (GIS), MSc (IT-Security)
> OSS Open Source Solutions GmbH
>
>
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==
Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
