On Wed, Sep 24, 2014 at 7:31 PM, Jody Garnett <jody.garn...@gmail.com>
wrote:
> +1 from me.
>
> I would like to move some of the REST API hacks from 2.6.x into
> ResourcePool (so we manage datastore caches in a consistent fashion).
>
> Actually with that in mind, and seeing you have a dispose() hook, I
> recommend:
>
> abstract class FeatureTypeHelper {
> boolean canHandle( FeatureTypeInfo, DataAccess );
> void initialize( FeatureTypeInfo, DataAccess ); // Called before
> FeatureTypeInfo accessed
> void flush( FeatureTypeInfo, DataAccess ); // Called before
> ContentState.flush()
> void dispose( FeatureTypeInfo, DataAccess ); // Called before
> DataAccess.dispose()
> }
>
No issue with the new method, but I find the Helper suffix rather confusing
(helper? helping what? what if we need a different set of "helps" in the
future?)
We already have a number of "*Initializer" things in GeoServer that manage
lifecycle, so at least this would be in line with those.
At most, if we want to make it clear it's a lifecycle thing, it could be
named FeatureTypeLifecyleHandler (which would mimic the
existing naming in GeoServerLifecycleHandler)
>
> ResourcePool is running around with a number of HashMaps that must be kept
> in sync. Something the REST API has not always managed in a consistent
> fashion with the GUI.
>
> My concern is FeatureTypeHelper would be used to manage additional
> external HashMaps outside of ResourcePool.
>
> Q: Is it worth structuring ResourcePool a bit better and allowing it to
> have a "user data" map? Or are DataStore implementations happy with
> subclassing ContentState (managed by flush and dispose above).
>
This is not the same topic as a FeatureTypeInitializer, I'd recommend to
start a different
thread to avoid confusion and make sure that has its own funding/resourcing
to go with it.
Cheers
Andrea
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
