On 25 November 2014 at 12:36, Andrea Aime <[email protected]>
wrote:
> On Tue, Nov 25, 2014 at 9:32 PM, Kevin Smith <[email protected]>
> wrote:
>
>> Yes, the idea is that subclasses should override this default
>> implementation with something that's properly encoded where possible
>> (Sometimes it's impossible). I wasn't able to provide such as many
>> implementations as I intended as I ran out of time.
>>
>
> I can see that, but see the main point of my first mail: it seems to me
> this filter is not necessary, we got a great speedup by just replacing it
> with Filter.INCLUDE, and leaving the
> secure catalog to do the filtering in memory (which is done right after
> calling this method).
>
> So I'm asking, can't we just kill it? For the in memory catalog it seems
> to do no useful work, and for JDBCConfig it's actually dragging down
> performance.
> Unless I'm missing something of course.
>
The filter that was being produced before did the same thing.
https://github.com/geoserver/geoserver/commit/887027a07aab01ef12fd9b0f7fe699c3d1bd46e8#diff-a9283370e69a44d55dfac0862028f589L1452
I tried to unravel buildPolicyWrapper to figure out if I could avoid this
but I couldn't convince myself that I could do without it without breaking
anything and so I gave up and just moved the whole thing into the default
implementation in AbstractResourceAccessManager.
>
>
>>
>> There are also some parts of the UI like the layer preview page that need
>> to be re-written to make use of the filter based API rather than filtering
>> things themselves. I didn't have time to get to that either.
>>
>
> We're working on it
>
Cool.
--
Kevin Smith
Junior Software Engineer | Boundless <http://boundlessgeo.com/>
[email protected]
+1-778-785-7459
@boundlessgeo <http://twitter.com/boundlessgeo/>
<http://twitter.com/boundlessgeo/>
[image: http://boundlessgeo.com/]
<http://boundlessgeo.com/>
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
