I don't want to hold up the pull request on this one, should be a 5 mins
conversation.
Andrea are these constructor arguments holding up?
Quick fix:
public GeoServerFeatureSource(source, schema, definitionQuery, declaredCRS,
srsHandling, linearizationTolerance){
this( source, schema, definitionQuery, declaredCRS, srsHandling,
linearizationTolerance, null );
}
Longer term:
// for backwards compatibility (deprecate or remove to force compile
failure)
GeoServerFeatureSource(source, schema, definitionQuery, declaredCRS,
srsHandling, linearizationTolerance){
this( source, new Settings( schema, definitionQuery, declaredCRS,
srsHandling, linearizationTolerance) );
}
GeoServerFeatureSource(source, schema, Settings settings ){
...
}
Where "GeoServerFeatureSource.Settings" is a parameter object we can add
fields to over time:
static class Settings {
SimpleFeatureType schema = null;
Filter definitionQuery = null;
CoordinateReferenceSystem declaredCRS = null;
int srsHandling = null;
Double linearizationTolerance = null;
Map<String, Object> metadata = null;
}
--
Jody Garnett
On 11 December 2014 at 00:16, Sampo Savolainen <
sampo.savolai...@spatineo.com> wrote:
> Hi,
>
> Jody and I have been discussing an API change in GeoServerFeatureSource
> that is in my pull request for cascaded stored query support.
>
> https://github.com/geoserver/geoserver/pull/841#discussion-diff-21494311
>
> The reasoning behind the change is to pass all metadata supplied for a
> feature type to the FeatureSource. This allows GeoServer to pass the
> configuration required for cascaded stored queries to the actual data
> store. The pattern is generic so it should be usable in other cases as well.
>
> Jody was looking for more feedback, especially from Andrea, regarding this.
>
>
> Thanks,
> Sampo
>
>
> --
> Sampo Savolainen
> R&D Director, Spatineo Oy
> sampo.savolai...@spatineo.com
> +358-407555649
> Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
> www.spatineo.com, twitter.com/#!/spatineo
> www.linkedin.com/company/spatineo-inc
>
> This message may contain privileged and/or confidential information. If you
> have received this e-mail in error or are not the intended recipient, you
> may not use, copy, disseminate, or distribute it; do not open any
> attachments, delete it immediately from your system and notify the sender
> promptly by e-mail that you have done so.
>
>
> ------------------------------------------------------------------------------
> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
> from Actuate! Instantly Supercharge Your Business Reports and Dashboards
> with Interactivity, Sharing, Native Excel Exports, App Integration & more
> Get technology previously reserved for billion-dollar corporations, FREE
>
> http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
> _______________________________________________
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
>
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
