On 18-03-15 17:10, Andrea Aime wrote: > Thank Niels, I don't think we have anyone reviewing pull requests from > this angle... I invite you to join > the team that checks the incoming pull requests and thus help increase > the GeoServer code quality
Andrea, I didn't mean to criticize this code so much, I'm convinced I sometimes write confusing code as well, I don't think anyone here doesn't. I was just surprised to read you say my fix didn't improve readability and then that it was merely personal and I had no arguments why it would be more readable for someone else, those remarks pushed me to go in to detail. I didn't originally mean any harm or blame with my original remark, I was just saying, this is a bug fix and makes it a little bit clearer what is happening, that is all. Also I have reviewed pull requests and will do so in the future as well. Regards Niels ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
