On 16/03/15 05:34, Andrea Aime wrote: > The first issue I see is that people are clearly not doing builds before > making pull requests
Despite this very recent discussion, committers a few moments ago not only broke the build on master, but also backported the breakage to 2.7.x and 2.6.x, winning the trifecta! Committers: (1) Which of you ran a local build for this change on any branch? (2) Who do you see as having responsibility for either running such a local build or ensuring that it has been run? It took my local build on master 15.465 seconds to fail. Not a huge effort. The evidence trail: master: https://github.com/geoserver/geoserver/pull/960 2.7.x: https://github.com/geoserver/geoserver/pull/978 2.6.x: https://github.com/geoserver/geoserver/pull/979 FAILED on master: http://ares.opengeo.org/jenkins/job/geoserver-master/1197/changes FAILED on 2.7.x: http://ares.opengeo.org/jenkins/job/geoserver-2.7.x/33/changes FAILED on 2.6.x: http://ares.opengeo.org/jenkins/job/geoserver-2.6.x/112/changes In my view, Jenkins is not a substitute for local builds. I view as one core tenet of continuous integration the principle that breaking the build should be avoided, and that the continuous integration server should be used to detect failures not found by local builds. In my experience, not following this principle leaves the build broken so often that continuous integration is lost. Kind regards, -- Ben Caradoc-Davies <[email protected]> Director Transient Software Limited <http://transient.nz> New Zealand ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
