On Sat, Apr 25, 2015 at 9:24 PM, Andrea Aime <[email protected]>
wrote:
> Simple idea, can we put a version.properties/version.txt in the security
> dir, containing the current
> version of the security dir contents (it would be 2.5 now).
> The first time we don't find it, go though the migrations, then create it,
> from that point on no need
> to go though the migrations at all.
>
> For data directories that miss completely a security setup (as it happens
> in some tests), wondering,
> can't we just use the security.zip of the tests, unpack it, and move on?
>
Hi,
I've played a bit with this idea, here is a branch that applies it and
indeed speeds up the build:
https://github.com/aaime/geoserver/tree/build_security_speedup
In particular, this commit:
https://github.com/aaime/geoserver/commit/ac4a915bfa238f7978efac3faff52eeed1267d2c
Simple partial build times comparison, only up to the wfs module.
Before:
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] GeoServer .......................................... SUCCESS [
1.630 s]
[INFO] Core Platform Module ............................... SUCCESS [
10.997 s]
[INFO] Open Web Service Module ............................ SUCCESS [
7.582 s]
[INFO] Main Module ........................................ SUCCESS [02:16
min]
[INFO] Web Feature Service Module ......................... SUCCESS [01:39
min]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 04:18 min
After:
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] GeoServer .......................................... SUCCESS [
1.358 s]
[INFO] Core Platform Module ............................... SUCCESS [
10.543 s]
[INFO] Open Web Service Module ............................ SUCCESS [
7.476 s]
[INFO] Main Module ........................................ SUCCESS [01:50
min]
[INFO] Web Feature Service Module ......................... SUCCESS [01:15
min]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 03:26 min
Overall, a significant speedup.
I've tried a full build too, but if fails in a couple of web-sec-core tests
and I'm having little
luck fixing it them: RoleListPageTest.testRemove
and ConfirmRemovalRolePanelTest.testRemoveRole
RoleListPageTest.testRemove apparently tries to remove all roles from a
list,
and in the normal version, only finds NEW_ROLE to select and delete, but
with
the patched version, the table also contains ROLE_ADMINISTRATOR, whose
removal makes a test fail (wondering, should this role be even removable?).
I haven't investigated the other failure.
Christian, do you have any clue?
Cheers
Andrea
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
