On Sun, May 10, 2015 at 4:57 AM, Jody Garnett <[email protected]>
wrote:
> Reviewed, you have really knocked this one out of the part - not sure I
> have ever seen a pull request so heavily commented.
>
As suggested in the pull request comments, I've reworked the spring bean
lazy loading so that
it's not the test that has to declare to desire eager loading, but it's the
beans that
need to be eagerly loaded that need to add lazy-init="false", like this:
https://github.com/geoserver/geoserver/pull/1033/files#diff-5b32e54953013fe49c4405ac132f9d3eR22
There is not that many needing this treatment, in general, they are beans
that
either alter their environment in the constructor (attaching listeners for
example) or
are application context aware, and doing the enviroment modification when
the
app context is set.
So, once the patch is applied, devs need to be on the lookout for this
situation, and
set the bean to not lazy init.
For the normal startup we are still going for full eager loading, it's best
to have
everything set before the OGC requests start hitting the server.
But for the tests, the speedup of lazy init, especially when running tests
from the
IDE, is too good to be left out (a single system test class run stand alone
does it job in
half of the time, 4-7 seconds instead of 10-14)
Cheers
Andrea
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
