> -----Original Message----- > From: Andrea Aime [mailto:[email protected]] > Sent: 20 May 2015 15:34 ... > Normally we prefer to point to local hosted schemas, as opposed to remote > ones, because in some enviroments there is just > no internet wide access and this allows clients to still download the schemas. In this case the locally hosted Schema is a very short one that imports two other Schemas from remote locations so it doesn't help for an isolated server. Also the download service schema location is a remote one, not locally hosted. This wasn't my primary concern but I noticed a comment in the code asking whether the xsd still needed to be locally hosted so I thought I'd just go ahead and make the change.
... > 2 - Miscellaneous tidying up of extended capabilities output > including: > Remove unnecessary namespace declarations > Remove unnecessary xsi:type attributes > > These are un-necessary... why? Because we derive them by importing the > DSL schema? Or just because they are not used? (sorry to ask, I'm not the > original author of the inspire plugin) The namespace declarations aren't used. The xsi:type attributes aren't needed as the Schemas define the concrete type of the elements to which they were attached. > Allow the service MetadataURL/MediaType element to be > omitted. It is optional. I intend to add the full list of 20+ types > enumerated in > the INSPIRE schema later. Currently only two options are allowed. > Don't include the extended capabilities element if the mandatory > parameters have not been set. > More tests for different combinations of parameters > (Reluctant to make separate tickets/commits for all these) > > I lost you there, the comment in the code says it's not used in download > services, but what about view ones, which we also support as WMS? I'm afraid I'm lost now :-( Which code comment are you referring to and what is not used in download services? I'm not sure to which bit of my message you are referring. I've written it slightly differently in the ticket I filed (GEOS-7042) so maybe that will be clearer? ... > About the extra tickets, you might want to make a generic "Assorted inspire > plugin improvements" one, provided you give a detailed > list of what changed, for the release notes and changelogs. I've split it into 4 tickets now with one being the "assorted stuff" one: https://osgeo-org.atlassian.net/browse/GEOS-7041 https://osgeo-org.atlassian.net/browse/GEOS-7042 https://osgeo-org.atlassian.net/browse/GEOS-7043 https://osgeo-org.atlassian.net/browse/GEOS-6435 > Had a quick look at the patches, from a glance I don't see anything wrong, but > others will probably want to review > once you make a pull request. > About the pull request, please follow our norms, one commit per jira ticket, > with the ticket number and title as the commit message As there are dependencies between the way I've currently written the code for each bit I've just submitted a pull request for the top ticket in the list above and will make further ones depending on whether that gets accepted/rejected/modified. Marcus Sen This message (and any attachments) is for the recipient only. NERC is subject to the Freedom of Information Act 2000 and the contents of this email and any reply you make may be disclosed by NERC unless it is exempt from release under the Act. Any material supplied to NERC may be stored in an electronic records management system. ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
