Hi Andrea, thanks for the review, I intended to issue a PR earlier but couldn't make it in time. Here it is: https://github.com/geoserver/geoserver/pull/1106
Unfortunately, I noticed your e-mail only after creating the PR, so the code does not take into account your comments. Tomorrow I'll update it accordingly. Il giorno mar, 16/06/2015 alle 18.35 +0200, Andrea Aime ha scritto: > On Fri, Jun 12, 2015 at 11:55 AM, Stefano Costa > <stefano.co...@geo-solutions.it> wrote: > > As a matter of fact, I do have a draft implementation of the > > former: > > > https://github.com/geoserver/geoserver/compare/master...ridethepenguin:app-schema-rest > > > Hi Stefano, > maybe next time you want to discuss some change make a pull request, > we have better tools > to comment and discuss if you do. > > > Anyways, here is a quick review: > 1) Avoid long winded comments about how the code used to look compared > to how it looks like > > in > https://github.com/geoserver/geoserver/compare/master...ridethepenguin:app-schema-rest#diff-1c2ca55edfdb0e4afc6249958dbe0bacR316 > just state why you are doing it, e.g. "this code makes sure we do > not create two app-schema stores with the same url, as that > would result in an exception" > 2) These checks should be un-necessary, the store just gave you the > names, they should be usable without extracting the local > > part: > https://github.com/geoserver/geoserver/compare/master...ridethepenguin:app-schema-rest#diff-1c2ca55edfdb0e4afc6249958dbe0bacR416 > If really needed, we might have a bug or other type of problem, > let's discuss > 3) I'd change the "disposableSource" into "createNewSource", all > DataAccess have a dispose method, they are all disposable, > we have to call dispose only if we created a new store/dataaccess > via its factory, instead of having it cached by resource pool > > > For the rest no particular comment (besides that the original code was > already scary), but we need a test please :-) > (adding a test scoped dependency to app-schema just to run the test) > > > Cheers > Andrea -- Best regards, Stefano Costa == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Dott. Stefano Costa Senior Software Engineer GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. ------------------------------------------------------------------------------ _______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
