On Sat, 1 Aug 2015 06:00:09 PM Andrea Aime wrote:
> The current result of the work is in this branch:
> https://github.com/geoserver/geoserver-cite-tools/tree/te-2015
I cloned it, and had a few problems. I eventually got it going though.
Just one PR for OGC code, and one PR for our code so far. One more
PR is likely needed: see below.

Do I need Jira tickets for geoserver-cite-tools fixes? If so, should they
be filed against CITE component in geoserver?
 
> Just like the current version, the TeamEngine and all the tests we
> care for are imported as submodule. Unlike the current version,
> the submodules import directly from specific revisions of the official
> repositories, the idea is that we're going to try to track the
> official tests, and if we need a fix, we are going to make pull
> requests against the official repos.
So if there is a problem with the OGC module, we fix it there? Not try to work
around it?

Example: I couldn't get the ant task to build. Turned out WFS 1.1
(and WCS 1.0) builds fail on my Linux box with JDK 8 (even if I run the
mvn task directly in the checked-out code).  I decided:

diff --git a/build.xml b/build.xml
index dc8c31e..6111afe 100644
--- a/build.xml
+++ b/build.xml
@@ -112,7 +112,7 @@                                                             
                                                                                
                                
       <arg line="install -DskipTests -nsu" />                                  
                                                                                
                                
     </exec>                                                                    
                                                                                
                                
     <exec dir="${basedir}/ets-wfs11" executable="mvn">                         
                                                                                
                                
-      <arg line="install -DskipTests -nsu" />
+      <arg line="install -DskipTests -nsu -Dmaven.compiler.source=1.5 
-Dmaven.compiler.target=1.5" />
     </exec>
     <exec dir="${basedir}/ets-wcs10" executable="mvn">
       <arg line="install -DskipTests -nsu" />

however specifying a source and target version inside the WFS 1.1 pom.xml
would also be an option. Which is preferred?
 
> So, in short, if you want to try the current tests on your machine,
> I would suggest to:
> * Checkout the tools
> * Switch to the te-2015 branch
> * For the first time, run "git submodule update --init" in order
>    to get all the submodule
> * ant clean build
> * ant webapp
> 
> Then connect at "http://localhost:9090/teamengine"; and start
> running the CITE tests you want.
Some of the tests also need data loaded, right? So should that
go into README.md?
 
> - ets-wms11: not sure but I believe it passed
I started here, and its failing. It looks like at least some real bugs. 
Should the approach be to log those issues into Jira in some
kind of logical group(s)? Then submit PRs as normal?

Brad

------------------------------------------------------------------------------
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to