Hi all, a PR is finally ready: https://github.com/geoserver/geoserver/pull/1170
As anticipated, I've factored out reusable logic from the OGR extension and created a new module, gs-ogr-core, on which both the new gdal-* and the old ogr-* modules are based. The refactoring has been done taking special care to ensure compatibility with previous versions of the OGR extension is not broken. Any feedback is appreciated. Thanks, Stefano Il giorno gio, 30/07/2015 alle 10.36 +0200, Stefano Costa ha scritto: > Hi, > I've created a JIRA for this: > https://osgeo-org.atlassian.net/browse/GEOS-7133 > > Jody, for now my plan is to factor out the shared logic from the OGR > extension and put it in a separate module for reuse: I have limited > resources left for this work, so I fear I won't be able to do much more > than this. > > Perhaps, once this is done, it will be clearer how we could move on and > design a general solution to invoking external tools via the command > line, also taking into account the work by Andrea in the importer > extension. > > Il giorno gio, 30/07/2015 alle 10.09 +0200, Andrea Aime ha scritto: > > On Thu, Jul 30, 2015 at 12:57 AM, Jody Garnett > > <[email protected]> wrote: > > Sounds good Stefano, > > > > > > I have been experimenting with exporting out coverage for > > processing by grass - and thus would be interested in > > factoring out shared logic (or at least doing things in a > > consistent fashion). > > > > > > Hi Jody, > > processing means WPS to me, not output format. You are referring to > > the logic used to call > > an external executable I suppose? > > > > > > GRASS is a bit complicated in that respect, it requires some work to > > setup the right environemt > > also in terms of directories and so on (the location and mapset), > > unless things have been simplified quite > > a bit since I last looked. > > Checking the 52 North integration, it still seems to be more than just > > "call an external executable > > with some command line options", although I cannot say I recognize > > this from my past experiences, > > it seems they are using some python command line intermediary: > > https://github.com/52North/WPS/tree/dev/52n-wps-grass/src/main/java/org/n52/wps/server/grass > > > > > > > > Going back to calling executables, Stefano's work builds on top of the > > existing OGR module, recently > > I added the ability to call gdal_translate in importer, and I've setup > > a generic command line > > transformation, but used a different library, which has been suggested > > by some colleagues of mine > > since it supports timeouts: > > https://github.com/geoserver/geoserver/blob/master/src/extension/importer/core/src/main/java/org/geoserver/importer/transform/AbstractCommandLineTransform.java > > > > > > > > Maybe code extracted from it could be a better base for a generic > > command line calling > > tool > > > > > > Cheers > > Andrea > > > > > > -- > > == > > GeoServer Professional Services from the experts! Visit > > http://goo.gl/it488V for more information. > > == > > > > > > > > Ing. Andrea Aime > > > > @geowolf > > Technical Lead > > > > > > GeoSolutions S.A.S. > > Via Poggio alle Viti 1187 > > 55054 Massarosa (LU) > > Italy > > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > > > > > http://www.geo-solutions.it > > http://twitter.com/geosolutions_it > > > > > > AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 > > > > Le informazioni contenute in questo messaggio di posta elettronica e/o > > nel/i file/s allegato/i sono da considerarsi strettamente riservate. > > Il loro utilizzo è consentito esclusivamente al destinatario del > > messaggio, per le finalità indicate nel messaggio stesso. Qualora > > riceviate questo messaggio senza esserne il destinatario, Vi preghiamo > > cortesemente di darcene notizia via e-mail e di procedere alla > > distruzione del messaggio stesso, cancellandolo dal Vostro sistema. > > Conservare il messaggio stesso, divulgarlo anche in parte, > > distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità > > diverse, costituisce comportamento contrario ai principi dettati dal > > D.Lgs. 196/2003. > > > > > > > > The information in this message and/or attachments, is intended solely > > for the attention and use of the named addressee(s) and may be > > confidential or proprietary in nature or covered by the provisions of > > privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New > > Data Protection Code).Any use not in accord with its purpose, any > > disclosure, reproduction, copying, distribution, or either > > dissemination, either whole or partial, is strictly forbidden except > > previous formal approval of the named addressee(s). If you are not the > > intended recipient, please contact immediately the sender by > > telephone, fax or e-mail and delete the information in this message > > that has been received in error. The sender does not give any warranty > > or accept liability as the content, accuracy or completeness of sent > > messages and accepts no responsibility for changes made after they > > were sent or for other risks which arise as a result of e-mail > > transmission, viruses, etc. > > > > > > > > > > ------------------------------------------------------- > -- Best regards, Stefano Costa == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Dott. Stefano Costa Senior Software Engineer GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. ------------------------------------------------------------------------------ _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
