Jody - those refer to the same point; I updated the proposal after that email was sent.
Torben On Mon, Aug 10, 2015 at 4:56 PM, Jody Garnett <[email protected]> wrote: > +1 > > Some additional discussion follows... > > On 10 August 2015 at 15:59, Torben Barsballe <[email protected]> > wrote: > >> Jody - It should be fairly easy to get importer to recognize style files: >> simply iterate through StyleHandlers to get the supported >> formats/extensions, and see if there are any matching files in the import. >> Such a change would be entirely distinct from the style generator. >> > > Right - you are correct StyleHandler includes the file extension :) > > Given that this does involve an API change to StyleHandler in gs-main, I >> have created a GSIP here: >> https://github.com/geoserver/geoserver/wiki/GSIP-131 >> >> I am also considering some other related improvements that may be usefull: >> >> - Allow importer to generate files of any format. >> - Allow style UI to generate styles. >> - Expose rest endpoint for generating styles. >> >> Your proposal already indicated "Add a new Generate from template style > section to the New/Edit Style page, with a drop-down menu to select a > template and a link to generate the style.". > > Is this different from "Allow style UI to generate styles" above? > -- > Jody > >> Torben >> >> On Mon, Aug 10, 2015 at 11:11 AM, Jody Garnett <[email protected]> >> wrote: >> >>> No problems, but perhaps a related request for importer / style >>> generation. >>> >>> uDig ships sample data with a sld sidecar file next to each shape file. >>> I would really like it if importer could recognize sld or css sidecar >>> files. >>> On Mon, Aug 10, 2015 at 10:18 AM Andrea Aime < >>> [email protected]> wrote: >>> >>>> On Mon, Aug 10, 2015 at 7:03 PM, Torben Barsballe < >>>> [email protected]> wrote: >>>> >>>>> The gs-importer extension generates default SLD styles for imported >>>>> layers. >>>>> >>>>> I would like to extend this functionality to support style generation >>>>> for arbitrary formats. >>>>> This would involve: >>>>> 1. Migrating org.geoserver.importer.StyleGenerator to the gs-main >>>>> catalog package >>>>> 2. Adding a generate() method to org.geoserver.catalog.StyleHandler, >>>>> using StyleGenerator to generates a format-specific style based on a >>>>> template. >>>>> >>>>> This change would allow us to define default templates for CSS styles >>>>> (and other extended formats) upon import. Since CSS has a rather different >>>>> stucture than SLD, this would provide a better default style than >>>>> generating SLD and immediately converting to CSS in cases where CSS was >>>>> used (Importer would still default to generating SLD). >>>>> >>>>> This functionality might also be usefull when creating new styles in >>>>> the geoserver styles page - upon creating a new style, a default template >>>>> for that format could be loaded. >>>>> >>>>> Given that this involves an API change to gs-main, I intend to get >>>>> this in before the Aug 18 code freeze. >>>>> >>>>> Does anyone have any concerns or objections to this change? >>>>> >>>> >>>> Not me, looking forward to see the pull request :-) >>>> >>>> Cheers >>>> Andrea >>>> >>>> >>>> -- >>>> == >>>> GeoServer Professional Services from the experts! Visit >>>> http://goo.gl/it488V for more information. >>>> == >>>> >>>> Ing. Andrea Aime >>>> @geowolf >>>> Technical Lead >>>> >>>> GeoSolutions S.A.S. >>>> Via Poggio alle Viti 1187 >>>> 55054 Massarosa (LU) >>>> Italy >>>> phone: +39 0584 962313 >>>> fax: +39 0584 1660272 >>>> mob: +39 339 8844549 >>>> >>>> http://www.geo-solutions.it >>>> http://twitter.com/geosolutions_it >>>> >>>> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* >>>> >>>> Le informazioni contenute in questo messaggio di posta elettronica e/o >>>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il >>>> loro utilizzo è consentito esclusivamente al destinatario del messaggio, >>>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo >>>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di >>>> darcene notizia via e-mail e di procedere alla distruzione del messaggio >>>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, >>>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od >>>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai >>>> principi dettati dal D.Lgs. 196/2003. >>>> >>>> >>>> >>>> The information in this message and/or attachments, is intended solely >>>> for the attention and use of the named addressee(s) and may be confidential >>>> or proprietary in nature or covered by the provisions of privacy act >>>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection >>>> Code).Any use not in accord with its purpose, any disclosure, reproduction, >>>> copying, distribution, or either dissemination, either whole or partial, is >>>> strictly forbidden except previous formal approval of the named >>>> addressee(s). If you are not the intended recipient, please contact >>>> immediately the sender by telephone, fax or e-mail and delete the >>>> information in this message that has been received in error. The sender >>>> does not give any warranty or accept liability as the content, accuracy or >>>> completeness of sent messages and accepts no responsibility for changes >>>> made after they were sent or for other risks which arise as a result of >>>> e-mail transmission, viruses, etc. >>>> >>>> ------------------------------------------------------- >>>> >>>> ------------------------------------------------------------------------------ >>>> _______________________________________________ >>>> Geoserver-devel mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>>> >>> -- >>> -- >>> Jody Garnett >>> >> >> >
------------------------------------------------------------------------------
_______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
