I have the test failing without the patch although the way I accomplished it isn't pretty.
https://github.com/geoserver/geoserver/pull/1220/commits -- Kevin Michael Smith [email protected] On Thu, Sep 17, 2015, at 01:16 PM, Kevin Smith wrote: > Reported as https://osgeo-org.atlassian.net/browse/GEOS-7203 > > I have a fix for the NPE, but fixing the unit tests that should have > caught this problem is proving extremely difficult. I just can't figure > out what Wicket is doing in order to get the test to replicate it. > > You can't leave the tile caching tab (by saving or switching tabs) while > the layer has no cache. This means the cache can't be removed via the > UI, and any changes made on other tabs will be lost if the user visits > the tile caching tab and doesn't turn on caching. This seems to be a > blocker level bug so if I can't get the test fixed today, we either need > to merge the fix without a test, or push back the release (or someone > else needs to get the unit test working) > > Fix: > > https://github.com/smithkm/geoserver/commit/f4bbc6ebcff8f63e871ceb9711df3ae3280103a9 > > Unit test that's failing to detect the problem: > > https://github.com/geoserver/geoserver/blob/master/src/web/gwc/src/test/java/org/geoserver/gwc/web/layer/LayerCacheOptionsTabPanelTest.java#L156 > > -- > Kevin Michael Smith > [email protected] > > ------------------------------------------------------------------------------ > Monitor Your Dynamic Infrastructure at Any Scale With Datadog! > Get real-time metrics from all of your servers, apps and tools > in one place. > SourceForge users - Click here to start your Free Trial of Datadog now! > http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140 > _______________________________________________ > Geoserver-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geoserver-devel ------------------------------------------------------------------------------ Monitor Your Dynamic Infrastructure at Any Scale With Datadog! Get real-time metrics from all of your servers, apps and tools in one place. SourceForge users - Click here to start your Free Trial of Datadog now! http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140 _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
