On Wed, Sep 30, 2015 at 6:17 PM, Stefano Costa < stefano.co...@geo-solutions.it> wrote:
> 1) The code so far is not pretty, as I'm basically doing if-else logic on > the feature type's datastore connection parameters directly inside the > org.geoserver.web.demo.PreviewLayer class. It would have been better to > setup some extension mechanism, like defining a GMLLinkProvider interface > for which modules like app-schema could provide implementations, that the > preview page would then look up via Spring and use to create the GML link. > Considering that so far, as I understand, app-schema layers are the only > one that need special treatment, do you think it is worth the effort > required to setup such mechanism? > No strong opinion either way > > 2) How am I going to test this? Ben, do you have any suggestions as to how > to quickly setup some app-schema layers to test? > Check the app schema integration test module in extension. Ben probably knows more/better ways, but while I'm answering... > > 3) I believe that for app-schema layers all WFS output formats which don't > support complex features (i.e. all but GML 3.1.1/3.2) should either not be > added to the list of available formats or return a nice error message, like > the KML output format does: "The KML output format can only be applied to > simple features" > We probably need to extend the WFS output format classes so that they report if they are complex feature aware, or not? > > 4) I believe the OpenLayers, KML and all WMS output formats should be > hidden if the published layer is geometryless, or the lat/lon bbox is > null/empty: should I prepare a second PR with this improvement as well? > Good idea Cheers Andrea -- == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -------------------------------------------------------
------------------------------------------------------------------------------
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
