Hi, I recently created a ticket with a pull request to make GetFeature queries faster for data stores where counting features is slow. https://osgeo-org.atlassian.net/browse/GEOS-7301
In my pull request I proposed adding a new field to FeatureTypeInfo that would allow GeoServer to skip counting features altogether (under certain conditions) that would make things faster, but break strict compatibility with some types of queries. However I only later noted there is a flag already which does this in part: skipNumberMatched. I updated the ticket with a new proposal that I'ld like to get some comments on: "I was looking at the existing flag in FeatureTypeInfo, skipNumberMatched. The implementation looks very close to what I'm trying to achieve here, but the current accepted implementation does not make GeoServer skip counting all features. More specifically, I'm referring to these rows of code: https://github.com/geoserver/geoserver/blob/2e19a4ebe7f9c3698ac3eecf002da76bff0aa506/src/wfs/src/main/java/org/geoserver/wfs/GetFeature.java#L531 https://github.com/geoserver/geoserver/blob/2e19a4ebe7f9c3698ac3eecf002da76bff0aa506/src/wfs/src/main/java/org/geoserver/wfs/GetFeature.java#L552 Would you be willing to accept a patch where those counts are skipped if both: - primary feature of the query has skipNumberMatched = true, and - there is only a single query in the GetFeature request (paging .. ? This would simplify this patch to only affecting GetFeature.java and remove the need for a new field in FeatureTypeInfo." Can you think of any new problems with this approach (meaning that I should stick with adding a new flag to FeatureTypeInfo) or should I update my pull request based on this idea? Sampo -- Sampo Savolainen Managing Director, Spatineo Oy [email protected] +358-407555649 Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland www.spatineo.com, twitter.com/#!/spatineo www.linkedin.com/company/spatineo-inc This message may contain privileged and/or confidential information. If you have received this e-mail in error or are not the intended recipient, you may not use, copy, disseminate, or distribute it; do not open any attachments, delete it immediately from your system and notify the sender promptly by e-mail that you have done so.
------------------------------------------------------------------------------
_______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
