Done:
https://github.com/geoserver/geoserver/pull/1398
It does not contain a test, it is needed?
Best regards
Alvaro
De: Andrea Aime <[email protected]>
Para: A Huarte <[email protected]>
CC: "[email protected]"
<[email protected]>
Enviado: Martes 12 de enero de 2016 16:17
Asunto: Re: [Geoserver-devel] Memory leak in GetMap ?
On Tue, Jan 12, 2016 at 3:59 PM, A Huarte <[email protected]> wrote:
Hi all, I get many LOG error messages: "Call MapContent dispose() to prevent
memory leaks"
Yeah, that log statement is unfortunate and annoying, as I believe a memory
leak can only be generated ifthere are layer and content listeners around, that
GeoServer does not use. But the check in the finalize method of MapContent is
dumband it just keeps on complaining for nothing.
I think that they come from GetMap method
(https://github.com/geoserver/geoserver/blob/master/src/wms/src/main/java/org/geoserver/wms/GetMap.java#L116)
when an error occurs. The MapContent object never is disposed, and finally GC
runs its finalize method.
I solve this issue adding the dispose call to the catch
clause:https://github.com/ahuarte47/geoserver/commit/7901f8bd404ae7f664b9a8795d2e7713dc871144
I am right?
Seems like a good point to add it
It makes sense to create a pull request to fix it?
Yes please.
CheersAndrea
--
==GeoServer Professional Services from the experts! Visithttp://goo.gl/it488V
for more information.==
Geosolutions' Winter Holidays from 24/12 to 6/1
Ing. Andrea Aime
@geowolfTechnical Lead
GeoSolutions S.A.S.Via Poggio alle Viti 118755054 Massarosa (LU)Italyphone:
+39 0584 962313fax: +39 0584 1660272mob: +39 339 8844549
http://www.geo-solutions.ithttp://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003Le informazioni contenute in questo
messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi
strettamente riservate. Il loro utilizzo è consentito esclusivamente al
destinatario del messaggio, per le finalità indicate nel messaggio stesso.
Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo
cortesemente di darcene notizia via e-mail e di procedere alla distruzione del
messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio
stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003. The information in this message and/or
attachments, is intended solely for the attention and use of the named
addressee(s) and may be confidential or proprietary in nature or covered by the
provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's
New Data Protection Code).Any use not in accord with its purpose, any
disclosure, reproduction, copying, distribution, or either dissemination,
either whole or partial, is strictly forbidden except previous formal approval
of the named addressee(s). If you are not the intended recipient, please
contact immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender does
not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes made
after they were sent or for other risks which arise as a result of e-mail
transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
