On 29/12/16 06:44, Andrea Aime wrote: > Giving uses 6 separate flags would mean allowing for 64 different potential > configurations instead of the 5 proposed. Seems like a nightmare to > understand and test, and some combinations would seem to be illegal to > start with, for example, a tree group that does not advertise children... > then it's not a tree? One would have to enumerate all possible cases and > see if they make sense, and then develop a set of tests at the catalog, > security and WMS caps level for each combination (see the tests I've > created for the work in progress for GSIP 153)... it would seem one would > have to develop something like 200 new tests.
I recognise that the use of properties rather than a small number of classes makes testing harder. This approach may be too general, for the reasons you detail above. Restriction through subclassing can be a good thing, and I am comfortable with it; I was just trying to identify the orthogonal characteristics of the problem, not saying that all combinations are valid or that exposing them is desirable. Kind regards, -- Ben Caradoc-Davies <[email protected]> Director Transient Software Limited <http://transient.nz/> New Zealand ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
