I think we should consider it a regression, the RC1 is already going out
but this can be fixed this prior to release.
--
Jody Garnett
On 10 March 2017 at 09:56, Nuno Oliveira <[email protected]>
wrote:
> Hi,
>
> The fix [1] for issue GEOS-7930 [2] changed the order of operations
> performed to update a style [3]. Before, the style resource (SLD file or
> example) was updated and then the catalog object was updated, this means
> that someone listening on styles catalog modified\post-modified events
> could safely assume that the style object and the associated resources
> were updated. The JMS community module was expecting this behavior.
>
> My first question is: should this be considered a regression ?
>
> In my opinion the old behavior makes sense, if I get an event from the
> catalog saying that a style was updated I would say it makes sense to
> assume that the associated resource was also updated.
>
> An alternative fix could be not changing the order in which the
> operations are performed, but instead persist the style resource using
> the old style path and let the GeoServer persister do is job. This will
> fix the issue and preserve the old behavior, which makes sense to me.
>
> Sorry for not detecting this when the PR was done and bring this now.
>
> Opinions on this ?
>
> Regards,
>
> Nuno Oliveira
>
> [1] https://github.com/geoserver/geoserver/pull/2075
> [2] https://osgeo-org.atlassian.net/browse/GEOS-7930
> [3]
> https://github.com/geoserver/geoserver/blob/master/src/web/
> wms/src/main/java/org/geoserver/wms/web/data/StyleEditPage.java#L111-L120
>
> --
> ==
> GeoServer Professional Services from the experts!
> Visit http://goo.gl/it488V for more information.
> ==
> Nuno Miguel Carvalho Oliveira
> @nmcoliveira
> Software Engineer
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> 55054 Massarosa (LU)
> Italy
>
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 333 8128928
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono
> da considerarsi strettamente riservate. Il loro utilizzo è consentito
> esclusivamente al destinatario del messaggio, per le finalità indicate
> nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il
> destinatario, Vi preghiamo cortesemente di darcene notizia via e
> -mail e di procedere alla distruzione del messaggio stesso, cancellandolo
> dal Vostro sistema. Conservare il messaggio stesso, divulgarlo
> anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo
> per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of
> the named addressee(s) and may be confidential or proprietary in nature or
> covered by the provisions of privacy act (Legislative Decree
> June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in
> accord with its purpose, any disclosure, reproduction, copying,
> distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content,
> accuracy or completeness of sent messages and accepts no responsibility
> for changes made after they were sent or for other risks which
> arise as a result of e-mail transmission, viruses, etc.
>
>
> ------------------------------------------------------------
> ------------------
> Announcing the Oxford Dictionaries API! The API offers world-renowned
> dictionary content that is easy and intuitive to access. Sign up for an
> account today to start using our lexical data to power your apps and
> projects. Get started today and enter our developer competition.
> http://sdm.link/oxford
> _______________________________________________
> Geoserver-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
