Erik, I am unhappy with this pull request because it makes Travis CI and ares Jenkins inconsistent. This affects all pull requests. I would rather have the geogig module back in the communityRelease profile and closely monitored by GeoGig developers. The recent failure was caused by an infrastructure problem not an API change (there was an API change but the corresponding fixes were immediately merged into GeoServer). I would rather have the ares build fail for a short time every now and then than break the consistency between Travis CI and ares Jenkins.
Another solution could be to make a stable GeoGig branch for GeoServer to consume and backport GeoGig API changes to this branch at your convenience. This will allow you to choose when to deal with API changes on the GeoServer side. You could achieve the same effect with GeoGig milestones or changing the GeoGig pom version. How much GeoGig API change is coming, and which approach do you think would be easiest? I have no problem with including the geogig module in the communityRelease profile right now if it compiles and will in the future receive your usual close attention. Kind regards, Ben. On 29/03/17 02:46, Erik Merkle wrote: > All, the LocationTech build servers that build the GeoGig core artifacts > appear to be functioning again. I'm going to re-trigger the build for this > PR: > > https://github.com/geoserver/geoserver/pull/2191 > > Merging this PR will compile the GeoGig module in the Travis build when a > GeoServer PR is created, but the GeoGig module will remain disabled in the > communityRelease for now. Once merged, GeoGig compilation/build issues may > cause GeoServer GitHub Travis builds to fail, but they won't cause > GeoServer builds to fail. If this is an acceptable measure, Jody would you > mind merging the PR and backporting. If this is not an acceptable measure, > please let me know and I will try to come up with a better solution. > > Again, my apologies for the inconveniences caused. When the GeoGig API gets > to a less fluid state, we (the GeoGig team) can propose to re-enable the > module in the communityRelease. > > Many thanks, > > Erik Merkle > Software Engineer | Boundless <http://boundlessgeo.com/> > > <http://d32wfbeasdaw38.cloudfront.net/img/Boundless_Logo.png> > > On Fri, Mar 24, 2017 at 2:25 PM, Jody Garnett <[email protected]> > wrote: > >> I have just set that up with Erik for master, if that works as intended we >> will back port to the other branches. >> >> -- >> Jody Garnett >> >> On 24 March 2017 at 00:19, Andrea Aime <[email protected]> >> wrote: >> >>> Hi, >>> I've previously sent a mail suggesting the geogig plugin to be built with >>> its own dedicated >>> build on ares, as it's frequently breaking the builds (compile wise) in >>> GeoServer. >>> This would also give you the added benefit of being able to run tests on >>> it :-) >>> >>> Cheers >>> Andrea >>> >>> >>> On Fri, Mar 24, 2017 at 1:54 AM, Ben Caradoc-Davies <[email protected]> >>> wrote: >>> >>>> Erik, >>>> >>>> GeoServer builds on all branches (master, 2.11.x, 2.10.x, and 2.9.x) are >>>> broken because the geogig-master build is failing and has not updated >>>> the 1.1-SNAPSHOT jars to include the most recent API changes: >>>> https://ci.locationtech.org/geogig/job/geogig-master/ >>>> >>>> Travis CI correctly identified that these pull requests would cause the >>>> GeoServer builds to fail. One of these checks had failed and three were >>>> still pending at the time that you merged these pull requests: >>>> https://github.com/geoserver/geoserver/pull/2183 >>>> https://github.com/geoserver/geoserver/pull/2186 >>>> https://github.com/geoserver/geoserver/pull/2185 >>>> https://github.com/geoserver/geoserver/pull/2184 >>>> >>>> Once the geogig-master build has been fixed, please restart all the >>>> failing GeoServer Jenkins builds and all the Travis CI branch builds and >>>> pull request builds that failed because of this outage. I can help with >>>> this step. >>>> >>>> Kind regards, >>>> >>>> -- >>>> Ben Caradoc-Davies <[email protected]> >>>> Director >>>> Transient Software Limited <http://transient.nz/> >>>> New Zealand >>>> >>>> ------------------------------------------------------------ >>>> ------------------ >>>> Check out the vibrant tech community on one of the world's most >>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >>>> _______________________________________________ >>>> Geoserver-devel mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>>> >>> >>> >>> >>> -- >>> == >>> GeoServer Professional Services from the experts! Visit >>> http://goo.gl/it488V for more information. >>> == >>> >>> Ing. Andrea Aime >>> @geowolf >>> Technical Lead >>> >>> GeoSolutions S.A.S. >>> Via di Montramito 3/A >>> 55054 Massarosa (LU) >>> phone: +39 0584 962313 <+39%200584%20962313> >>> fax: +39 0584 1660272 <+39%200584%20166%200272> >>> mob: +39 339 8844549 <+39%20339%20884%204549> >>> >>> http://www.geo-solutions.it >>> http://twitter.com/geosolutions_it >>> >>> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* >>> >>> Le informazioni contenute in questo messaggio di posta elettronica e/o >>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il >>> loro utilizzo è consentito esclusivamente al destinatario del messaggio, >>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo >>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di >>> darcene notizia via e-mail e di procedere alla distruzione del messaggio >>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, >>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od >>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai >>> principi dettati dal D.Lgs. 196/2003. >>> >>> >>> >>> The information in this message and/or attachments, is intended solely >>> for the attention and use of the named addressee(s) and may be confidential >>> or proprietary in nature or covered by the provisions of privacy act >>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection >>> Code).Any use not in accord with its purpose, any disclosure, reproduction, >>> copying, distribution, or either dissemination, either whole or partial, is >>> strictly forbidden except previous formal approval of the named >>> addressee(s). If you are not the intended recipient, please contact >>> immediately the sender by telephone, fax or e-mail and delete the >>> information in this message that has been received in error. The sender >>> does not give any warranty or accept liability as the content, accuracy or >>> completeness of sent messages and accepts no responsibility for changes >>> made after they were sent or for other risks which arise as a result of >>> e-mail transmission, viruses, etc. >>> >>> ------------------------------------------------------- >>> >>> ------------------------------------------------------------ >>> ------------------ >>> Check out the vibrant tech community on one of the world's most >>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >>> _______________________________________________ >>> Geoserver-devel mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>> >>> >> > -- Ben Caradoc-Davies <[email protected]> Director Transient Software Limited <http://transient.nz/> New Zealand ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
