Ian, good catch. That might have easily have affected a user. Just when we thought we had sanitised all our inputs ...
Kind regards, Ben. On 24/05/17 23:00, Ian Turton wrote: > OK I've managed to dig to the bottom of this one - > https://github.com/geoserver/geoserver/pull/2357 > > Longer answer - for some reason I have some environment variables > like BACKGROUND_CYAN= [46m (with an Escape char at the start) in my user > env. If you pass these unescaped to the Dom parser it chokes, but of course > my eclipse env and travis and jenkins etc don't have that issue. > > Ian > > On 24 May 2017 at 08:51, Andrea Aime <andrea.a...@geo-solutions.it> wrote: > >> Hi Ian, >> does it make sense to change the test so that it dumps the raw xml (as a >> string) to the output >> before trying to parse it? Would likely help to see what might be wrong >> with it. >> >> Cheers >> Andrea >> >> >> On Wed, May 24, 2017 at 9:42 AM, Ian Turton <ijtur...@gmail.com> wrote: >> >>> mvn -version: >>> >>> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; >>> 2015-11-10T16:41:47+00:00) >>> Maven home: /usr/share/maven-3.3.9 >>> Java version: 1.8.0_66, vendor: Oracle Corporation >>> Java home: /usr/lib/jvm/jdk1.8.0_66/jre >>> Default locale: en_GB, platform encoding: UTF-8 >>> OS name: "linux", version: "3.19.0-32-generic", arch: "amd64", family: >>> "unix" >>> >>> The error is on the first call in that method (Document dom = >>> getAsDOM(BASEPATH + "/about/status");) and the full stack trace is: >>> >>> org.xml.sax.SAXParseException; lineNumber: 44; columnNumber: 306; An >>> invalid XML character (Unicode: 0x1b) was found in the element content of >>> the document. >>> at com.sun.org.apache.xerces.internal.parsers.DOMParser.parse( >>> DOMParser.java:257) >>> at com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl. >>> parse(DocumentBuilderImpl.java:339) >>> at org.geoserver.test.GeoServerSystemTestSupport.dom(GeoServerS >>> ystemTestSupport.java:1498) >>> at org.geoserver.test.GeoServerSystemTestSupport.dom(GeoServerS >>> ystemTestSupport.java:1477) >>> at org.geoserver.test.GeoServerSystemTestSupport.getAsDOM(GeoSe >>> rverSystemTestSupport.java:1376) >>> at org.geoserver.test.GeoServerSystemTestSupport.getAsDOM(GeoSe >>> rverSystemTestSupport.java:1232) >>> at org.geoserver.rest.catalog.AboutControllerTest.testGetStatus >>> AsHTML(AboutControllerTest.java:100) >>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce >>> ssorImpl.java:62) >>> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe >>> thodAccessorImpl.java:43) >>> at java.lang.reflect.Method.invoke(Method.java:497) >>> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall( >>> FrameworkMethod.java:47) >>> at org.junit.internal.runners.model.ReflectiveCallable.run(Refl >>> ectiveCallable.java:12) >>> at org.junit.runners.model.FrameworkMethod.invokeExplosively(Fr >>> ameworkMethod.java:44) >>> at org.junit.internal.runners.statements.InvokeMethod.evaluate( >>> InvokeMethod.java:17) >>> at org.junit.internal.runners.statements.RunBefores.evaluate( >>> RunBefores.java:26) >>> at org.junit.internal.runners.statements.RunAfters.evaluate(Run >>> Afters.java:27) >>> at org.junit.rules.RunRules.evaluate(RunRules.java:20) >>> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) >>> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit >>> 4ClassRunner.java:70) >>> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit >>> 4ClassRunner.java:50) >>> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) >>> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) >>> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) >>> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) >>> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) >>> at org.junit.internal.runners.statements.RunBefores.evaluate( >>> RunBefores.java:26) >>> at org.junit.internal.runners.statements.RunAfters.evaluate(Run >>> Afters.java:27) >>> at org.junit.runners.ParentRunner.run(ParentRunner.java:309) >>> at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUni >>> t4Provider.java:242) >>> at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestS >>> et(JUnit4Provider.java:137) >>> at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit >>> 4Provider.java:112) >>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce >>> ssorImpl.java:62) >>> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe >>> thodAccessorImpl.java:43) >>> at java.lang.reflect.Method.invoke(Method.java:497) >>> at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodW >>> ithArray(ReflectionUtils.java:189) >>> at org.apache.maven.surefire.booter.ProviderFactory$ProviderPro >>> xy.invoke(ProviderFactory.java:165) >>> at org.apache.maven.surefire.booter.ProviderFactory.invokeProvi >>> der(ProviderFactory.java:85) >>> at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInPro >>> cess(ForkedBooter.java:115) >>> at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBoo >>> ter.java:75) >>> >>> >>> >>> On 23 May 2017 at 22:33, Ben Caradoc-Davies <b...@transient.nz> wrote: >>> >>>> Ian, >>>> >>>> a full build is passing for master on Boundless Jenkins, Travis CI, and >>>> for me locally on debian unstable amd64 with OpenJDK 8. >>>> >>>> As Andrea wrote, most likely a platform encoding issue. What is your >>>> platform and encoding? What is the output of "mvn -version"? You could also >>>> try a full "mvn clean install" build. >>>> >>>> Do you have a stack trace with line numbers? Does it fail for the first >>>> or second test request? >>>> >>>> Kind regards, >>>> Ben. >>>> >>>> >>>> On 24/05/17 03:02, Ian Turton wrote: >>>> >>>>> I'm currently getting a build failure with mvn but not eclipse on a >>>>> fresh >>>>> checkout of master in RestConfig: >>>>> >>>>> Tests in error: >>>>> testGetStatusAsHTML(org.geoserver.rest.catalog.AboutControllerTest): >>>>> An >>>>> invalid XML character (Unicode: 0x1b) was found in the element content >>>>> of >>>>> the document. >>>>> >>>>> Obviously I can't actually find that character in the file - has anyone >>>>> seen anything similar? >>>>> >>>>> Ian >>>>> >>>>> >>>>> >>>>> ------------------------------------------------------------ >>>>> ------------------ >>>>> Check out the vibrant tech community on one of the world's most >>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Geoserver-devel mailing list >>>>> Geoserver-devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>>>> >>>>> >>>> -- >>>> Ben Caradoc-Davies <b...@transient.nz> >>>> Director >>>> Transient Software Limited <http://transient.nz/> >>>> New Zealand >>>> >>> >>> >>> >>> -- >>> Ian Turton >>> >>> ------------------------------------------------------------ >>> ------------------ >>> Check out the vibrant tech community on one of the world's most >>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >>> _______________________________________________ >>> Geoserver-devel mailing list >>> Geoserver-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>> >>> >> >> >> -- >> == >> GeoServer Professional Services from the experts! Visit >> http://goo.gl/it488V for more information. >> == >> >> Ing. Andrea Aime >> @geowolf >> Technical Lead >> >> GeoSolutions S.A.S. >> Via di Montramito 3/A >> 55054 Massarosa (LU) >> phone: +39 0584 962313 <+39%200584%20962313> >> fax: +39 0584 1660272 <+39%200584%20166%200272> >> mob: +39 339 8844549 <+39%20339%20884%204549> >> >> http://www.geo-solutions.it >> http://twitter.com/geosolutions_it >> >> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* >> >> Le informazioni contenute in questo messaggio di posta elettronica e/o >> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il >> loro utilizzo è consentito esclusivamente al destinatario del messaggio, >> per le finalità indicate nel messaggio stesso. Qualora riceviate questo >> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di >> darcene notizia via e-mail e di procedere alla distruzione del messaggio >> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, >> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od >> utilizzarlo per finalità diverse, costituisce comportamento contrario ai >> principi dettati dal D.Lgs. 196/2003. >> >> >> >> The information in this message and/or attachments, is intended solely for >> the attention and use of the named addressee(s) and may be confidential or >> proprietary in nature or covered by the provisions of privacy act >> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection >> Code).Any use not in accord with its purpose, any disclosure, reproduction, >> copying, distribution, or either dissemination, either whole or partial, is >> strictly forbidden except previous formal approval of the named >> addressee(s). If you are not the intended recipient, please contact >> immediately the sender by telephone, fax or e-mail and delete the >> information in this message that has been received in error. The sender >> does not give any warranty or accept liability as the content, accuracy or >> completeness of sent messages and accepts no responsibility for changes >> made after they were sent or for other risks which arise as a result of >> e-mail transmission, viruses, etc. >> >> ------------------------------------------------------- >> > > > -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <http://transient.nz/> New Zealand ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
